Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 14320040: Revert 194356 "views: Finally get rid of the deprecated Menu2 API." (Closed)

Created:
7 years, 8 months ago by msw
Modified:
7 years, 8 months ago
Reviewers:
tfarina
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194356 "views: Finally get rid of the deprecated Menu2 API." > views: Finally get rid of the deprecated Menu2 API. > > BUG=None > TEST=None > R=sky@chromium.org,msw@chromium.org > > Review URL: https://codereview.chromium.org/14150005 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195259

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -71 lines) Patch
M trunk/src/chrome/browser/ui/views/frame/system_menu_insertion_delegate_win.h View 1 chunk +4 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/system_menu_insertion_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + trunk/src/ui/views/controls/menu/menu_2.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ui/views/controls/menu/menu_2.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/ui/views/controls/menu/menu_insertion_delegate.h View 1 chunk +0 lines, -21 lines 0 comments Download
A + trunk/src/ui/views/controls/menu/menu_wrapper.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ui/views/controls/menu/native_menu_win.h View 1 chunk +16 lines, -33 lines 0 comments Download
M trunk/src/ui/views/controls/menu/native_menu_win.cc View 9 chunks +19 lines, -9 lines 0 comments Download
M trunk/src/ui/views/views.gyp View 4 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
msw
7 years, 8 months ago (2013-04-19 19:55:56 UTC) #1
msw
7 years, 8 months ago (2013-04-19 19:56:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r195259.

Powered by Google App Engine
This is Rietveld 408576698