Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: trunk/src/media/tools/player_x11/player_x11.cc

Issue 14320005: Revert 194993 "Remove reference counting from media::VideoDecode..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/media/filters/vpx_video_decoder.cc ('k') | trunk/src/webkit/media/filter_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/media/tools/player_x11/player_x11.cc
===================================================================
--- trunk/src/media/tools/player_x11/player_x11.cc (revision 195011)
+++ trunk/src/media/tools/player_x11/player_x11.cc (working copy)
@@ -113,13 +113,12 @@
media::FFmpegNeedKeyCB need_key_cb = base::Bind(&NeedKey);
collection->SetDemuxer(new media::FFmpegDemuxer(message_loop, data_source,
need_key_cb));
+ collection->GetVideoDecoders()->push_back(new media::FFmpegVideoDecoder(
+ message_loop));
-
- ScopedVector<media::VideoDecoder> video_decoders;
- video_decoders.push_back(new media::FFmpegVideoDecoder(message_loop));
+ // Create our video renderer and save a reference to it for painting.
scoped_ptr<media::VideoRenderer> video_renderer(new media::VideoRendererBase(
message_loop,
- video_decoders.Pass(),
media::SetDecryptorReadyCB(),
base::Bind(&Paint, paint_message_loop, paint_cb),
base::Bind(&SetOpaque),
« no previous file with comments | « trunk/src/media/filters/vpx_video_decoder.cc ('k') | trunk/src/webkit/media/filter_helpers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698