Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1431953003: Fix several uses of ScopedTempDir in components_unittests. (Closed)

Created:
5 years, 1 month ago by wkorman
Modified:
5 years, 1 month ago
Reviewers:
bengr, jgorski, jianli, sclittle
CC:
chromium-reviews, darin-cc_chromium.org, jam, wifiprefetch-reviews_google.com, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix several uses of ScopedTempDir in components_unittests. BUG=546640 Committed: https://crrev.com/c1e71b647c44e68c89c5fc1fe8ef62553d54a7ca Cr-Commit-Position: refs/heads/master@{#358692}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M components/gcm_driver/gcm_client_impl_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/precache/content/precache_manager_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/precache/core/precache_database_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
wkorman
+jgorski/jianli for components/gcm_driver. +bengr/sclittle for components/precache.
5 years, 1 month ago (2015-11-09 22:09:53 UTC) #2
wkorman
Actually +bengr/sclittle for components/precache this time.
5 years, 1 month ago (2015-11-09 22:10:16 UTC) #4
jianli
gcm_driver lgtm
5 years, 1 month ago (2015-11-09 22:11:20 UTC) #5
sclittle
components/precache LGTM
5 years, 1 month ago (2015-11-09 22:12:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431953003/1
5 years, 1 month ago (2015-11-09 22:15:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-09 22:56:11 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 22:57:12 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c1e71b647c44e68c89c5fc1fe8ef62553d54a7ca
Cr-Commit-Position: refs/heads/master@{#358692}

Powered by Google App Engine
This is Rietveld 408576698