Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/precache/content/precache_manager_unittest.cc

Issue 1431953003: Fix several uses of ScopedTempDir in components_unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/precache/content/precache_manager_unittest.cc
diff --git a/components/precache/content/precache_manager_unittest.cc b/components/precache/content/precache_manager_unittest.cc
index e7dc6d051e38ac465faf00c7511d7a4062d663bb..bccbbdab8c0bb0788a49bdcb340c3783ee048c2b 100644
--- a/components/precache/content/precache_manager_unittest.cc
+++ b/components/precache/content/precache_manager_unittest.cc
@@ -21,6 +21,7 @@
#include "components/history/core/browser/history_service.h"
#include "components/history/core/browser/history_types.h"
#include "components/precache/core/precache_switches.h"
+#include "content/public/browser/browser_thread.h"
#include "content/public/test/test_browser_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "net/http/http_status_code.h"
@@ -146,8 +147,9 @@ class PrecacheManagerTest : public testing::Test {
net::URLRequestStatus::FAILED);
}
- content::TestBrowserThreadBundle test_browser_thread_bundle_;
+ // Must be declared first so that it is destroyed last.
content::TestBrowserContext browser_context_;
+ content::TestBrowserThreadBundle test_browser_thread_bundle_;
PrecacheManagerUnderTest precache_manager_;
TestURLFetcherCallback url_callback_;
net::FakeURLFetcherFactory factory_;
« no previous file with comments | « components/gcm_driver/gcm_client_impl_unittest.cc ('k') | components/precache/core/precache_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698