Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1431803004: [Interpreter] Fix U16() calls in test-bytecode-generator for big endian. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix U16() calls in test-bytecode-generator for big endian. Avoid double incrementing the variable in the U16() macro. BUG=v8:4280 LOG=N Committed: https://crrev.com/5486eb6b3da405f294e4c22f759b636b9c92fbfd Cr-Commit-Position: refs/heads/master@{#31803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M test/cctest/interpreter/test-bytecode-generator.cc View 13 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rmcilroy
An alternative to https://codereview.chromium.org/1423593005/. PTAL, thanks.
5 years, 1 month ago (2015-11-04 18:33:36 UTC) #3
paul.l...
This looks good, Ross, thanks. I'll test it to be sure, results in ~10 min.
5 years, 1 month ago (2015-11-04 18:48:24 UTC) #5
paul.l...
LGTM. Fixes test-bytecode-generator/PropertyLoads & friends. Thanks! (However, this won't fix big-endian bots, new issue, with ...
5 years, 1 month ago (2015-11-04 19:05:23 UTC) #6
rmcilroy
On 2015/11/04 19:05:23, paul.l... wrote: > LGTM. Fixes test-bytecode-generator/PropertyLoads & friends. Thanks! > > (However, ...
5 years, 1 month ago (2015-11-04 19:07:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431803004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431803004/1
5 years, 1 month ago (2015-11-04 19:07:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 19:38:54 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 19:39:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5486eb6b3da405f294e4c22f759b636b9c92fbfd
Cr-Commit-Position: refs/heads/master@{#31803}

Powered by Google App Engine
This is Rietveld 408576698