Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1431803004: [Interpreter] Fix U16() calls in test-bytecode-generator for big endian. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index 11a88e93a97c960c8c2db8d950ff3ad03acf9fb8..654e3c1bdb25701c1a74be4b397ac4e5745afc25 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -771,7 +771,7 @@ TEST(HeapNumberConstants) {
REPEAT_256(COMMA, //
B(LdaConstant), U8(wide_idx++), //
B(Star), R(0)), //
- B(LdaConstantWide), U16(wide_idx++), //
+ B(LdaConstantWide), U16(wide_idx), //
B(Star), R(0), //
B(LdaUndefined), //
B(Return), //
@@ -944,7 +944,7 @@ TEST(PropertyLoads) {
REPEAT_127(COMMA, //
B(LoadICSloppy), A(1, 2), U8(0), U8((wide_idx_1 += 2)), //
B(Star), R(0)), //
- B(LoadICSloppyWide), A(1, 2), U16(0), U16(wide_idx_1 += 2), //
+ B(LoadICSloppyWide), A(1, 2), U16(0), U16(wide_idx_1 + 2), //
B(Return), //
},
1,
@@ -962,7 +962,7 @@ TEST(PropertyLoads) {
REPEAT_127(COMMA, //
B(LoadICStrict), A(1, 2), U8(0), U8((wide_idx_2 += 2)), //
B(Star), R(0)), //
- B(LoadICStrictWide), A(1, 2), U16(0), U16(wide_idx_2 += 2), //
+ B(LoadICStrictWide), A(1, 2), U16(0), U16(wide_idx_2 + 2), //
B(Return), //
},
1,
@@ -982,7 +982,7 @@ TEST(PropertyLoads) {
B(KeyedLoadICSloppy), A(1, 3), U8((wide_idx_3 += 2)), //
B(Star), R(0)), //
B(Ldar), A(2, 3), //
- B(KeyedLoadICSloppyWide), A(1, 3), U16(wide_idx_3 += 2), //
+ B(KeyedLoadICSloppyWide), A(1, 3), U16(wide_idx_3 + 2), //
B(Return), //
}},
{
@@ -1000,7 +1000,7 @@ TEST(PropertyLoads) {
B(KeyedLoadICStrict), A(1, 3), U8((wide_idx_4 += 2)), //
B(Star), R(0)), //
B(Ldar), A(2, 3), //
- B(KeyedLoadICStrictWide), A(1, 3), U16(wide_idx_4 += 2), //
+ B(KeyedLoadICStrictWide), A(1, 3), U16(wide_idx_4 + 2), //
B(Return), //
}},
};
@@ -1136,7 +1136,7 @@ TEST(PropertyStores) {
B(LdaSmi8), U8(1), //
B(StoreICSloppy), A(1, 2), U8(0), U8((wide_idx_1 += 2))), //
B(LdaSmi8), U8(2), //
- B(StoreICSloppyWide), A(1, 2), U16(0), U16(wide_idx_1 += 2), //
+ B(StoreICSloppyWide), A(1, 2), U16(0), U16(wide_idx_1 + 2), //
B(LdaUndefined), //
B(Return), //
},
@@ -1155,7 +1155,7 @@ TEST(PropertyStores) {
B(LdaSmi8), U8(1), //
B(StoreICStrict), A(1, 2), U8(0), U8((wide_idx_2 += 2))), //
B(LdaSmi8), U8(2), //
- B(StoreICStrictWide), A(1, 2), U16(0), U16(wide_idx_2 += 2), //
+ B(StoreICStrictWide), A(1, 2), U16(0), U16(wide_idx_2 + 2), //
B(LdaUndefined), //
B(Return), //
},
@@ -1175,7 +1175,7 @@ TEST(PropertyStores) {
U8((wide_idx_3 += 2))), //
B(LdaSmi8), U8(2), //
B(KeyedStoreICSloppyWide), A(1, 3), A(2, 3), //
- U16(wide_idx_3 += 2), //
+ U16(wide_idx_3 + 2), //
B(LdaUndefined), //
B(Return), //
}},
@@ -1194,7 +1194,7 @@ TEST(PropertyStores) {
U8((wide_idx_4 += 2))), //
B(LdaSmi8), U8(2), //
B(KeyedStoreICStrictWide), A(1, 3), A(2, 3), //
- U16(wide_idx_4 += 2), //
+ U16(wide_idx_4 + 2), //
B(LdaUndefined), //
B(Return), //
}}};
@@ -1347,7 +1347,7 @@ TEST(LoadGlobal) {
{
REPEAT_127(COMMA, //
B(LoadICSloppy), A(1, 2), U8(0), U8(wide_idx_1 += 2)), //
- B(LdaGlobalSloppyWide), U16(1), U16(wide_idx_1 += 2), //
+ B(LdaGlobalSloppyWide), U16(1), U16(wide_idx_1 + 2), //
B(Return), //
},
2,
@@ -1362,7 +1362,7 @@ TEST(LoadGlobal) {
{
REPEAT_127(COMMA, //
B(LoadICStrict), A(1, 2), U8(0), U8(wide_idx_2 += 2)), //
- B(LdaGlobalStrictWide), U16(1), U16(wide_idx_2 += 2), //
+ B(LdaGlobalStrictWide), U16(1), U16(wide_idx_2 + 2), //
B(Return), //
},
2,
@@ -1451,7 +1451,7 @@ TEST(StoreGlobal) {
REPEAT_127(COMMA, //
B(LoadICSloppy), A(1, 2), U8(0), U8(wide_idx_1 += 2)), //
B(LdaSmi8), U8(2), //
- B(StaGlobalSloppyWide), U16(1), U16(wide_idx_1 += 2), //
+ B(StaGlobalSloppyWide), U16(1), U16(wide_idx_1 + 2), //
B(LdaUndefined), //
B(Return), //
},
@@ -1468,7 +1468,7 @@ TEST(StoreGlobal) {
REPEAT_127(COMMA, //
B(LoadICStrict), A(1, 2), U8(0), U8(wide_idx_2 += 2)), //
B(LdaSmi8), U8(2), //
- B(StaGlobalStrictWide), U16(1), U16(wide_idx_2 += 2), //
+ B(StaGlobalStrictWide), U16(1), U16(wide_idx_2 + 2), //
B(LdaUndefined), //
B(Return), //
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698