Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1431713004: MimeHandlerViewGuest: Ignore title changes due to navigations. (Closed)

Created:
5 years, 1 month ago by Sam McNally
Modified:
5 years, 1 month ago
Reviewers:
raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MimeHandlerViewGuest: Ignore title changes due to navigations. Currently, when a mime handler is loaded, the URL of the mime handler is used as the embedder's title. This causes that title to flicker between the URL of the content, the URL of the mime handler and the title set by the mime handler. This changes MimeHandlerViewGuest to only update the embedder's title when the mime handler's title changes without the URL also changing. BUG=47914 Committed: https://crrev.com/3493265a42600578d77e75a398c0659c301c5228 Cr-Commit-Position: refs/heads/master@{#358778}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Sam McNally
5 years, 1 month ago (2015-11-04 06:50:02 UTC) #4
Sam McNally
PTAL
5 years, 1 month ago (2015-11-10 02:04:19 UTC) #5
raymes
lgtm
5 years, 1 month ago (2015-11-10 02:07:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431713004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431713004/60001
5 years, 1 month ago (2015-11-10 03:15:51 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 1 month ago (2015-11-10 03:21:27 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 03:22:46 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3493265a42600578d77e75a398c0659c301c5228
Cr-Commit-Position: refs/heads/master@{#358778}

Powered by Google App Engine
This is Rietveld 408576698