Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Issue 1431713004: MimeHandlerViewGuest: Ignore title changes due to navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
index 55b2426eab7da641a14c52ae87de91e380525b9a..1f9ebfbb7b7acc4bc814c2ec972acbb81bdd7e2a 100644
--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
@@ -169,6 +169,11 @@ void MimeHandlerViewGuest::NavigationStateChanged(
if (!(changed_flags & content::INVALIDATE_TYPE_TITLE))
return;
+ // Only consider title changes not triggered by URL changes. Otherwise, the
+ // URL of the mime handler will be displayed.
+ if (changed_flags & content::INVALIDATE_TYPE_URL)
+ return;
+
if (!is_full_page_plugin())
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698