Issue 14316009: Update tools to reflect movement of TestExpectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14316009: Update tools to reflect movement of TestExpectations (Closed)

Created:
7 years, 8 months ago by Steve Block

Modified:
7 years, 8 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update tools to reflect movement of TestExpectations Also fix SVN URL in test_expectations*.py to use src.chromium.org after blink fork. Also fix test_expectations_history_unittest.py to use correct time zone. Commit time stamps are in UTC, so we need to specify date ranges in UTC, rather than local time, to ensure consistent behaviour in all locations. BUG=230264 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194752

Patch Set 1 #

Patch Set 2 : Fix equality test #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -43 lines)			Patch
M	media/tools/layout_tests/README	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/tools/layout_tests/test_expectations.py	View		2 chunks	+4 lines, -5 lines	0 comments	Download
M	media/tools/layout_tests/test_expectations_history.py	View	1	3 chunks	+19 lines, -15 lines	0 comments	Download
M	media/tools/layout_tests/test_expectations_history_unittest.py	View		4 chunks	+12 lines, -13 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View		3 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

DaleCurtis

Thanks for looking at this! Did you find this via code search or are you ...

7 years, 8 months ago (2013-04-17 20:45:32 UTC) #2

Steve Block

np. I did the move of TestExpectations to its new location and simply came across ...

7 years, 8 months ago (2013-04-18 00:52:15 UTC) #3

Steve Block

7 years, 8 months ago (2013-04-18 02:12:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r194752 (presubmit successful).

Expand Messages | Collapse Messages