OLD | NEW |
1 # This file should almost always be empty. Normally Chromium test expectations | 1 # This file should almost always be empty. Normally Chromium test expectations |
2 # are only put here temporarily, and moved to | 2 # are only put here temporarily, and moved to |
3 # src/third_party/WebKit/LayoutTests/platform/chromium/TestExpectations | 3 # src/third_party/WebKit/LayoutTests/TestExpectations where they will remain |
4 # where they will remain until they are rebaselined. | 4 # until they are rebaselined. |
5 # | 5 # |
6 # | 6 # |
7 # If you are landing a Chromium CL that would break webkit layout tests, | 7 # If you are landing a Chromium CL that would break webkit layout tests, |
8 # please follow these steps: | 8 # please follow these steps: |
9 # | 9 # |
10 # 1. Add expected failures to the bottom of this file, and run your CL through | 10 # 1. Add expected failures to the bottom of this file, and run your CL through |
11 # various *_layout trybots. Confirm that the trybot results are green (any | 11 # various *_layout trybots. Confirm that the trybot results are green (any |
12 # failures are masked by the expectations you added to this file). | 12 # failures are masked by the expectations you added to this file). |
13 # | 13 # |
14 # 2. BEFORE landing your Chromium CL, land a WebKit CL adding those same | 14 # 2. BEFORE landing your Chromium CL, land a WebKit CL adding those same |
15 # expected failures to | 15 # expected failures to |
16 # src/third_party/WebKit/LayoutTests/platform/chromium/TestExpectations . | 16 # src/third_party/WebKit/LayoutTests/TestExpectations . If you are unable to do |
17 # If you are unable to do this yourself, please get a WebKit Committer to do | 17 # this yourself, please get a WebKit Committer to do it for you, or at least |
18 # it for you, or at least coordinate with a current WebKit Gardener to make | 18 # coordinate with a current WebKit Gardener to make sure she is aware of the |
19 # sure she is aware of the pending breakages. | 19 # pending breakages. |
20 # | 20 # |
21 # 3. AFTER you have landed the WebKit test_expectations CL, you can land your | 21 # 3. AFTER you have landed the WebKit test_expectations CL, you can land your |
22 # Chromium CL. Be sure to include your expected failures in this file, so | 22 # Chromium CL. Be sure to include your expected failures in this file, so |
23 # that other tip-of-tree Chromium developers will not be disturbed by your | 23 # that other tip-of-tree Chromium developers will not be disturbed by your |
24 # change. | 24 # change. |
25 # | 25 # |
26 # | 26 # |
27 # Every time Chromium's "WebKit Gardener" rolls the WebKit DEPS within | 27 # Every time Chromium's "WebKit Gardener" rolls the WebKit DEPS within |
28 # Chromium, he will delete ALL expectations within this file. (By then, they | 28 # Chromium, he will delete ALL expectations within this file. (By then, they |
29 # will be redundant, because you already landed those same expectations in | 29 # will be redundant, because you already landed those same expectations in |
30 # src/third_party/WebKit/LayoutTests/platform/chromium/TestExpectations . | 30 # src/third_party/WebKit/LayoutTests/TestExpectations . Right?) |
31 # Right?) | |
32 # | 31 # |
33 # EVERYTHING BELOW THIS LINE WILL BE DELETED AT EVERY WEBKIT DEPS ROLL | 32 # EVERYTHING BELOW THIS LINE WILL BE DELETED AT EVERY WEBKIT DEPS ROLL |
OLD | NEW |