Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/Source/core/animation/StringKeyframe.cpp

Issue 1431593004: Web Animations: Migrate SVG Rect interpolation to interpolation types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/StringKeyframe.cpp
diff --git a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
index 10d3bb3c3fc0f1c938a52093d048a2c34c59b64b..6801cb60c2a7f5d9d2fd5faa9c0c8ac973dfb8a3 100644
--- a/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
+++ b/third_party/WebKit/Source/core/animation/StringKeyframe.cpp
@@ -37,9 +37,9 @@
#include "core/animation/NumberSVGInterpolation.h"
#include "core/animation/PathSVGInterpolation.h"
#include "core/animation/PointSVGInterpolation.h"
-#include "core/animation/RectSVGInterpolation.h"
#include "core/animation/SVGAngleInterpolationType.h"
#include "core/animation/SVGNumberInterpolationType.h"
+#include "core/animation/SVGRectInterpolationType.h"
#include "core/animation/SVGStrokeDasharrayStyleInterpolation.h"
#include "core/animation/SVGValueInterpolationType.h"
#include "core/animation/TransformSVGInterpolation.h"
@@ -322,6 +322,8 @@ const Vector<const InterpolationType*>* applicableTypesForProperty(PropertyHandl
applicableTypes->append(new SVGValueInterpolationType(attribute));
} else if (attribute == SVGNames::orientAttr) {
applicableTypes->append(new SVGAngleInterpolationType(attribute));
+ } else if (attribute == SVGNames::viewBoxAttr) {
+ applicableTypes->append(new SVGRectInterpolationType(attribute));
} else {
fallbackToLegacy = true;
}
@@ -580,14 +582,13 @@ PassRefPtr<Interpolation> createSVGInterpolation(SVGPropertyBase* fromValue, SVG
case AnimatedPoints:
interpolation = ListSVGInterpolation<PointSVGInterpolation>::maybeCreate(fromValue, toValue, attribute);
break;
- case AnimatedRect:
- return RectSVGInterpolation::create(fromValue, toValue, attribute);
case AnimatedTransformList:
interpolation = ListSVGInterpolation<TransformSVGInterpolation>::maybeCreate(fromValue, toValue, attribute);
break;
// Handled by SVGInterpolationTypes.
case AnimatedAngle:
+ case AnimatedRect:
case AnimatedNumber:
ASSERT_NOT_REACHED();
// Fallthrough.
« no previous file with comments | « third_party/WebKit/Source/core/animation/SVGRectInterpolationType.cpp ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698