Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: mojo/application/public/interfaces/content_handler.mojom

Issue 1431573002: Fix hangs in Mandoline page cycler on Linux with --enable-multiprocess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/application/public/cpp/lib/content_handler_factory.cc ('k') | mojo/fetcher/about_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application/public/interfaces/content_handler.mojom
diff --git a/mojo/application/public/interfaces/content_handler.mojom b/mojo/application/public/interfaces/content_handler.mojom
index 4281bf6278e39589b84a4ced5fd3fcdbf30939dc..7494a7bf027976133acce92e3adc4dd6675f11cd 100644
--- a/mojo/application/public/interfaces/content_handler.mojom
+++ b/mojo/application/public/interfaces/content_handler.mojom
@@ -7,6 +7,14 @@ module mojo;
import "mojo/application/public/interfaces/application.mojom";
import "network/public/interfaces/url_loader.mojom";
+// Interface implemented by content handlers. To avoid race conditions with
+// dropped requests, the implementation should keep a reference to the lifetime
+// of the app (by holding on to AppRefCount). Each application started by
+// StartApplication should call the callback given by that method on
+// destruction. When the owner in the shell notices this, it will destroy the
+// interface pointer, which should cause the strongly-bound ContentHandler
+// implementation to self destruct and release the app reference.
interface ContentHandler {
- StartApplication(Application& application, URLResponse response);
+ // The callback should be called when the application is destructed.
+ StartApplication(Application& application, URLResponse response) => ();
};
« no previous file with comments | « mojo/application/public/cpp/lib/content_handler_factory.cc ('k') | mojo/fetcher/about_fetcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698