mojo/fetcher/about_fetcher_unittest.cc - Issue 1431573002: Fix hangs in Mandoline page cycler on Linux with --enable-multiprocess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/fetcher/about_fetcher_unittest.cc

Issue 1431573002: Fix hangs in Mandoline page cycler on Linux with --enable-multiprocess. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/application/public/interfaces/content_handler.mojom ('k') | mojo/package_manager/capability_filter_content_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/fetcher/about_fetcher_unittest.cc

diff --git a/mojo/fetcher/about_fetcher_unittest.cc b/mojo/fetcher/about_fetcher_unittest.cc

index dd7087e820dc82a1e5a667dfb910058fd22ec02d..1537d22339ff0d6e5bc00842c51e57ff41466c05 100644

--- a/mojo/fetcher/about_fetcher_unittest.cc

+++ b/mojo/fetcher/about_fetcher_unittest.cc

@@ -51,10 +51,13 @@ class TestContentHandler : public ApplicationDelegate,

}

// Overridden from ContentHandler:

- void StartApplication(InterfaceRequest<Application> application,

- URLResponsePtr response) override {

+ void StartApplication(

+ InterfaceRequest<Application> application,

+ URLResponsePtr response,

+ const Callback<void()>& destruct_callback) override {

response_number_++;

latest_response_ = response.Pass();

+ destruct_callback.Run();

// Drop |application| request. This results in the application manager

// dropping the ServiceProvider interface request provided by the client