Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1431473003: Mark GetCallingContext as soon-to-be deprecated (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark GetCallingContext as soon-to-be deprecated The calling context is the second top-most non-debugger context on the stack, but that's not necessarily the actually calling context, e.g., when a tail-call was used. BUG=chromium:541703 R=verwaest@chromium.org LOG=y Committed: https://crrev.com/16ca5c61025dd414b33afa88db0b8c287bac2f26 Cr-Commit-Position: refs/heads/master@{#31719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -74 lines) Patch
M include/v8.h View 2 chunks +9 lines, -3 lines 0 comments Download
M test/cctest/test-accessors.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -64 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-10-30 13:16:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431473003/1
5 years, 1 month ago (2015-10-30 13:42:21 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 14:53:51 UTC) #5
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-02 09:24:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431473003/1
5 years, 1 month ago (2015-11-02 19:02:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 19:22:40 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 19:23:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16ca5c61025dd414b33afa88db0b8c287bac2f26
Cr-Commit-Position: refs/heads/master@{#31719}

Powered by Google App Engine
This is Rietveld 408576698