Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 1431443003: Refactor Object::SetSuperProperty and others. (Closed)

Created:
5 years, 1 month ago by neis
Modified:
5 years, 1 month ago
Reviewers:
rossberg, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor Object::SetSuperProperty and others. This is in preparation of implementing Reflect.set. Besides making SetSuperProperty and others return Maybe<bool>, this CL also fixes some parts of my previous refactoring of SetProperty and others: It doesn't make sense to take both a language_mode and a should_throw argument. A strict language_mode should imply THROW_ON_ERROR. R=rossberg, verwaest@chromium.org BUG= Committed: https://crrev.com/127366112cb667fbe4a208d8c85121f9f23229a2 Cr-Commit-Position: refs/heads/master@{#31678}

Patch Set 1 #

Patch Set 2 : Revert unintended change to test262 status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -188 lines) Patch
M src/api-natives.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download
M src/objects.h View 1 7 chunks +16 lines, -25 lines 0 comments Download
M src/objects.cc View 1 30 chunks +97 lines, -134 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
neis
5 years, 1 month ago (2015-10-29 11:56:10 UTC) #1
rossberg
lgtm
5 years, 1 month ago (2015-10-29 16:43:57 UTC) #2
Toon Verwaest
lgtm
5 years, 1 month ago (2015-10-30 09:32:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431443003/1
5 years, 1 month ago (2015-10-30 09:47:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431443003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431443003/20001
5 years, 1 month ago (2015-10-30 10:08:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 10:45:41 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 10:46:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/127366112cb667fbe4a208d8c85121f9f23229a2
Cr-Commit-Position: refs/heads/master@{#31678}

Powered by Google App Engine
This is Rietveld 408576698