Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: src/ic/ic.cc

Issue 1431443003: Refactor Object::SetSuperProperty and others. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Revert unintended change to test262 status file. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api-natives.cc ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/ic/ic.h" 5 #include "src/ic/ic.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 1568 matching lines...) Expand 10 before | Expand all | Expand 10 after
1579 ASSIGN_RETURN_ON_EXCEPTION( 1579 ASSIGN_RETURN_ON_EXCEPTION(
1580 isolate(), result, 1580 isolate(), result,
1581 Object::SetProperty(object, name, value, language_mode(), store_mode), 1581 Object::SetProperty(object, name, value, language_mode(), store_mode),
1582 Object); 1582 Object);
1583 return result; 1583 return result;
1584 } 1584 }
1585 1585
1586 LookupIterator it(object, name); 1586 LookupIterator it(object, name);
1587 if (FLAG_use_ic) UpdateCaches(&it, value, store_mode); 1587 if (FLAG_use_ic) UpdateCaches(&it, value, store_mode);
1588 1588
1589 // Set the property. 1589 MAYBE_RETURN_NULL(
1590 Handle<Object> result; 1590 Object::SetProperty(&it, value, language_mode(), store_mode));
1591 ASSIGN_RETURN_ON_EXCEPTION( 1591 return value;
1592 isolate(), result,
1593 Object::SetProperty(&it, value, language_mode(), store_mode), Object);
1594 return result;
1595 } 1592 }
1596 1593
1597 1594
1598 Handle<Code> CallIC::initialize_stub(Isolate* isolate, int argc, 1595 Handle<Code> CallIC::initialize_stub(Isolate* isolate, int argc,
1599 CallICState::CallType call_type) { 1596 CallICState::CallType call_type) {
1600 CallICTrampolineStub stub(isolate, CallICState(argc, call_type)); 1597 CallICTrampolineStub stub(isolate, CallICState(argc, call_type));
1601 Handle<Code> code = stub.GetCode(); 1598 Handle<Code> code = stub.GetCode();
1602 return code; 1599 return code;
1603 } 1600 }
1604 1601
(...skipping 1539 matching lines...) Expand 10 before | Expand all | Expand 10 after
3144 KeyedLoadICNexus nexus(vector, vector_slot); 3141 KeyedLoadICNexus nexus(vector, vector_slot);
3145 KeyedLoadIC ic(IC::EXTRA_CALL_FRAME, isolate, &nexus); 3142 KeyedLoadIC ic(IC::EXTRA_CALL_FRAME, isolate, &nexus);
3146 ic.UpdateState(receiver, key); 3143 ic.UpdateState(receiver, key);
3147 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, ic.Load(receiver, key)); 3144 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, result, ic.Load(receiver, key));
3148 } 3145 }
3149 3146
3150 return *result; 3147 return *result;
3151 } 3148 }
3152 } // namespace internal 3149 } // namespace internal
3153 } // namespace v8 3150 } // namespace v8
OLDNEW
« no previous file with comments | « src/api-natives.cc ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698