Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 14314004: Axis aligned shader-based rect drawing (Closed)

Created:
7 years, 8 months ago by robertphillips
Modified:
7 years, 7 months ago
Reviewers:
jvanverth1, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This adds a specialized rect effect for Axis Aligned rects. It is faster then the general rect effect but still not always faster then the geometric approach (geometry on left - axis aligned on right): Win7 drawpointsdash_1_1_aa GPU c 65.91 70.51 -4.60 -7.0% drawpointsdash_5_5_aa GPU c 21.76 23.24 -1.48 -6.8% aarects GPU c 36.66 38.92 -2.26 -6.2% drawpointsdash_3_1_aa GPU c 30.89 32.21 -1.32 -4.3% tablebench GPU c 24.96 25.82 -0.86 -3.4% MacPro drawpointsdash_3_1_aa GPU c 37.40 40.33 -2.93 -7.8% drawpointsdash_1_1_aa GPU c 85.36 91.90 -6.54 -7.7% aarects GPU c 47.60 51.26 -3.66 -7.7% drawpointsdash_5_5_aa GPU c 26.74 27.92 -1.18 -4.4% tablebench GPU c 35.05 35.14 -0.09 -0.3% Nexus 7 drawpointsdash_5_5_aa GPU c 323.14 210.74 +112.40 +34.8% tablebench GPU c 337.85 173.46 +164.39 +48.7% aarects GPU c 2494.74 1065.79 +1428.95 +57.3% drawpointsdash_3_1_aa GPU c 822.38 310.22 +512.16 +62.3% drawpointsdash_1_1_aa GPU c 4676.73 1060.48 +3616.25 +77.3% I would like to land this disabled as a checkpoint.

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Disabled shader-based rect drawing #

Total comments: 9

Patch Set 4 : Addressed code review issues (renaming & API change) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -33 lines) Patch
M include/gpu/GrAARectRenderer.h View 1 2 3 2 chunks +35 lines, -10 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 2 3 7 chunks +192 lines, -16 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
7 years, 7 months ago (2013-04-29 19:39:05 UTC) #1
bsalomon
https://codereview.chromium.org/14314004/diff/2002/include/gpu/GrAARectRenderer.h File include/gpu/GrAARectRenderer.h (right): https://codereview.chromium.org/14314004/diff/2002/include/gpu/GrAARectRenderer.h#newcode54 include/gpu/GrAARectRenderer.h:54: void shaderFillAAAARect(GrGpu* gpu, umm... AlignedAARect? https://codereview.chromium.org/14314004/diff/2002/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): ...
7 years, 7 months ago (2013-04-29 19:44:50 UTC) #2
jvanverth1
https://codereview.chromium.org/14314004/diff/2002/include/gpu/GrAARectRenderer.h File include/gpu/GrAARectRenderer.h (right): https://codereview.chromium.org/14314004/diff/2002/include/gpu/GrAARectRenderer.h#newcode54 include/gpu/GrAARectRenderer.h:54: void shaderFillAAAARect(GrGpu* gpu, Yes, at first glance it's unclear ...
7 years, 7 months ago (2013-04-29 19:46:28 UTC) #3
jvanverth1
One other comment: https://codereview.chromium.org/14314004/diff/2002/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/14314004/diff/2002/src/gpu/GrAARectRenderer.cpp#newcode467 src/gpu/GrAARectRenderer.cpp:467: Is this different from 0.5*devRect.width() + ...
7 years, 7 months ago (2013-04-29 20:02:42 UTC) #4
robertphillips
PTAL https://codereview.chromium.org/14314004/diff/2002/include/gpu/GrAARectRenderer.h File include/gpu/GrAARectRenderer.h (right): https://codereview.chromium.org/14314004/diff/2002/include/gpu/GrAARectRenderer.h#newcode54 include/gpu/GrAARectRenderer.h:54: void shaderFillAAAARect(GrGpu* gpu, Done (shaderFillAlignedAARect). https://codereview.chromium.org/14314004/diff/2002/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp ...
7 years, 7 months ago (2013-05-02 13:56:39 UTC) #5
bsalomon
lgtm
7 years, 7 months ago (2013-05-02 14:02:16 UTC) #6
robertphillips
7 years, 7 months ago (2013-05-02 15:37:39 UTC) #7
Message was sent while issue was closed.
committed as r8960

Powered by Google App Engine
This is Rietveld 408576698