Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: tools/gn/ninja_binary_target_writer_unittest.cc

Issue 1431323003: Remove obsolete OS handling in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_copy_target_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_binary_target_writer_unittest.cc
diff --git a/tools/gn/ninja_binary_target_writer_unittest.cc b/tools/gn/ninja_binary_target_writer_unittest.cc
index 3de68e83587c31ce91a6b81a5575dd5d808dae5b..0765ba65425ac4008ef6b1949d7ddbbf10fc00bc 100644
--- a/tools/gn/ninja_binary_target_writer_unittest.cc
+++ b/tools/gn/ninja_binary_target_writer_unittest.cc
@@ -15,7 +15,6 @@ TEST(NinjaBinaryTargetWriter, SourceSet) {
Err err;
setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
- setup.settings()->set_target_os(Settings::WIN);
Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
target.set_output_type(Target::SOURCE_SET);
@@ -152,7 +151,6 @@ TEST(NinjaBinaryTargetWriter, ProductExtensionAndInputDeps) {
Err err;
setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
- setup.settings()->set_target_os(Settings::LINUX);
// An action for our library to depend on.
Target action(setup.settings(), Label(SourceDir("//foo/"), "action"));
@@ -208,7 +206,6 @@ TEST(NinjaBinaryTargetWriter, EmptyProductExtension) {
Err err;
setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
- setup.settings()->set_target_os(Settings::LINUX);
// This test is the same as ProductExtension, except that
// we call set_output_extension("") and ensure that we still get the default.
@@ -250,7 +247,6 @@ TEST(NinjaBinaryTargetWriter, EmptyProductExtension) {
TEST(NinjaBinaryTargetWriter, SourceSetDataDeps) {
TestWithScope setup;
setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
- setup.settings()->set_target_os(Settings::LINUX);
Err err;
@@ -332,7 +328,6 @@ TEST(NinjaBinaryTargetWriter, SourceSetDataDeps) {
TEST(NinjaBinaryTargetWriter, SharedLibraryModuleDefinitionFile) {
TestWithScope setup;
setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
- setup.settings()->set_target_os(Settings::WIN);
Target shared_lib(setup.settings(), Label(SourceDir("//foo/"), "bar"));
shared_lib.set_output_type(Target::SHARED_LIBRARY);
« no previous file with comments | « tools/gn/ninja_binary_target_writer.cc ('k') | tools/gn/ninja_copy_target_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698