Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1431183003: Set the correct style on the middle anonymous block in continuations (Closed)

Created:
5 years, 1 month ago by rhogan
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, darin-cc_chromium.org, eae+blinkwatch, jam, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the correct style on the middle anonymous block in continuations When we split an inline, ensure that the middle anonymous block gets the same style as the anonymous blocks on either side - i.e. the style of the block parent. BUG=286660 Committed: https://crrev.com/93aa8f022e5f79698d5e6ecd48f29eec8289f067 Cr-Commit-Position: refs/heads/master@{#359399}

Patch Set 1 #

Patch Set 2 : Updated #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-generated-content/before-content-continuation-chain-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-generated-content/before-content-continuation-chain-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/writing-mode/direction-of-middle-block-in-continuation.html View 1 chunk +14 lines, -0 lines 1 comment Download
A third_party/WebKit/LayoutTests/fast/writing-mode/direction-of-middle-block-in-continuation-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/block/basic/001-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/block/basic/001-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/css/child-style-can-override-visited-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug56024-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug56024-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
rhogan
5 years, 1 month ago (2015-11-10 20:20:04 UTC) #2
rhogan
5 years, 1 month ago (2015-11-12 18:43:38 UTC) #5
leviw_travelin_and_unemployed
lgtm Geez... good call
5 years, 1 month ago (2015-11-12 19:24:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431183003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431183003/20001
5 years, 1 month ago (2015-11-12 19:27:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-12 21:45:55 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/93aa8f022e5f79698d5e6ecd48f29eec8289f067 Cr-Commit-Position: refs/heads/master@{#359399}
5 years, 1 month ago (2015-11-12 21:46:45 UTC) #10
Julien - ping for review
5 years, 1 month ago (2015-11-13 16:03:49 UTC) #11
Message was sent while issue was closed.
lgtm2 (sorry for the delay yesterday was crazy and I couldn't get to your patch)

https://codereview.chromium.org/1431183003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/writing-mode/direction-of-middle-block-in-continuation.html
(right):

https://codereview.chromium.org/1431183003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/writing-mode/direction-of-middle-block-in-continuation.html:11:
<span style="display: block; height: 100px; width: 88px; margin: 10px; border:
1px solid green; background-color:green;"></span>
<span style="display:block"> 

*cough, cough* <div> (it's a nit though)

Powered by Google App Engine
This is Rietveld 408576698