third_party/WebKit/Source/core/layout/LayoutInline.cpp - Issue 1431183003: Set the correct style on the middle anonymous block in continuations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutInline.cpp

Issue 1431183003: Set the correct style on the middle anonymous block in continuations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/writing-mode/direction-of-middle-block-in-continuation.html ('K') | « third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug56024-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutInline.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutInline.cpp b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

index 5c2818783f18865fb20372027c0394e6bf50e36a..ee32a7c017e5db26a25c3e13a0a4a8f15b5c8b13 100644

--- a/third_party/WebKit/Source/core/layout/LayoutInline.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutInline.cpp

@@ -307,7 +307,7 @@ void LayoutInline::addChildIgnoringContinuation(LayoutObject* newChild, LayoutOb

// inline into continuations. This involves creating an anonymous block box to hold

// |newChild|. We then make that block box a continuation of this inline. We take all of

// the children after |beforeChild| and put them in a clone of this object.

- RefPtr<ComputedStyle> newStyle = ComputedStyle::createAnonymousStyleWithDisplay(styleRef(), BLOCK);

+ RefPtr<ComputedStyle> newStyle = ComputedStyle::createAnonymousStyleWithDisplay(containingBlock()->styleRef(), BLOCK);

// If inside an inline affected by in-flow positioning the block needs to be affected by it too.

// Giving the block a layer like this allows it to collect the x/y offsets from inline parents later.