Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1431143002: GYP+GN plumbing for SSE4.2, AVX, and AVX2 in Skia. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
djsollen, dcheng
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GYP+GN plumbing for SSE4.2, AVX, and AVX2 in Skia. This doesn't change any code yet: each of the sse42, avx, and avx2_sources is a list with a single empty .cpp file. Remember https://codereview.chromium.org/1290423007 ? This is part 2, and parts 1 and 3 have already landed. GYP config in Skia: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/gyp/opts.gyp&l=140 GYP config for libvpx: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libvpx_new/libvpx_srcs_x86_64_intrinsics.gypi&l=97 GN config for libvpx: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libvpx_new/BUILD.gn&l=159 BUG=skia:4117 Committed: https://crrev.com/6c88d596d0ab59817b358250d6bf51a2264b6461 Cr-Commit-Position: refs/heads/master@{#359108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -6 lines) Patch
M skia/BUILD.gn View 3 chunks +53 lines, -2 lines 0 comments Download
M skia/skia_library_opts.gyp View 5 chunks +104 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431143002/1
5 years, 1 month ago (2015-11-09 16:28:42 UTC) #3
mtklein_C
5 years, 1 month ago (2015-11-09 16:33:58 UTC) #6
djsollen
I follow the logic for the Skia stuff, but am at a total loss when ...
5 years, 1 month ago (2015-11-09 16:59:13 UTC) #7
mtklein
On 2015/11/09 at 16:59:13, djsollen wrote: > I follow the logic for the Skia stuff, ...
5 years, 1 month ago (2015-11-09 17:01:37 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-09 17:51:57 UTC) #10
mtklein_C
Updated the CL description with some GYP/GN references: our local GYPs for {SSE42, AVX, AVX2} ...
5 years, 1 month ago (2015-11-09 19:56:54 UTC) #12
djsollen
lgtm
5 years, 1 month ago (2015-11-10 03:31:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431143002/1
5 years, 1 month ago (2015-11-10 04:10:19 UTC) #15
mtklein_C
On 2015/11/10 at 04:10:19, commit-bot wrote: > CQ is trying da patch. Follow status at ...
5 years, 1 month ago (2015-11-10 04:11:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431143002/1
5 years, 1 month ago (2015-11-11 16:19:14 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 17:37:27 UTC) #20
dcheng
FYI, this breaks the win clang x64 debug build: http://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/2519/steps/generate_build_files/logs/stdio
5 years, 1 month ago (2015-11-12 03:43:36 UTC) #22
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 19:58:19 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c88d596d0ab59817b358250d6bf51a2264b6461
Cr-Commit-Position: refs/heads/master@{#359108}

Powered by Google App Engine
This is Rietveld 408576698