Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1290423007: Add build targets for advanced Intel instruction sets (1 of 3). (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add build targets for advanced Intel instruction sets (1 of 3). CL (1 of 3) adds empty lists in our .gypi, and builds the files in those empty lists with the appropriate flags. CL (2 of 3) will have Chrome's GYP and GN files read these lists, and build them with the appropriate flags. CL (3 of 3) will add runtime detection and stub files to the lists with empty Init_sse42(), Init_avx(), Init_avx2() methods. After that, we should be able to use SSE 4.2, AVX, and AVX2 if desired. Some motivation: - SSE 4.2 adds some sweet string-oriented methods that can help us write fast high quality 32-bit hashes. - AVX is SSE doubled, e.g. 8 floats or two SkPMFloat at a time. - AVX2 is SSE2 doubled, e.g. 8 pixels at a time. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/5141d90796034a932a48738cf76091957314c9a1

Patch Set 1 #

Patch Set 2 : gyp,preconfig #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -5 lines) Patch
M gyp/opts.gyp View 1 2 chunks +55 lines, -1 line 0 comments Download
M gyp/opts.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M include/core/SkPreConfig.h View 1 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290423007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290423007/20001
5 years, 4 months ago (2015-08-19 22:48:00 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 22:55:23 UTC) #4
mtklein_C
5 years, 4 months ago (2015-08-19 22:56:12 UTC) #6
djsollen
lgtm
5 years, 4 months ago (2015-08-20 14:48:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290423007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290423007/20001
5 years, 4 months ago (2015-08-24 17:26:09 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 17:32:05 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5141d90796034a932a48738cf76091957314c9a1

Powered by Google App Engine
This is Rietveld 408576698