Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1431023002:
[Telemetry] Check whether powermetrics service has already terminated and fail gracefully (Closed)
Description[Telemetry] Check whether powermetrics service has already terminated and fail gracefully
This is a reland of http://crrev.com/1410553009#ps40001
Last time the patch landed, the only failed test was
benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.tab_switching.typical_25
Patch run on Mac10.9 swarming slave:
https://chromium-swarm.appspot.com/user/task/2af247b85b5f6610
BUG=551405
Committed: https://crrev.com/56bd9aa8be4606cf7d4c9aea5e76157c688a1ba3
Cr-Commit-Position: refs/heads/master@{#358193}
Patch Set 1 : #
Total comments: 1
Messages
Total messages: 19 (8 generated)
Patchset #2 (id:20001) has been deleted
https://codereview.chromium.org/1431023002/diff/40001/tools/telemetry/telemet... File tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py (right): https://codereview.chromium.org/1431023002/diff/40001/tools/telemetry/telemet... tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:91: return {} This is the fix
Patchset #2 (id:40001) has been deleted
Description was changed from ========== [Telemetry] Check whether powermetrics service has already terminated and fail gracefully This is a reland of http://crrev.com/1410553009#ps40001 BUG=551405 ========== to ========== [Telemetry] Check whether powermetrics service has already terminated and fail gracefully This is a reland of http://crrev.com/1410553009#ps40001 Last time the patch landed, the only failed test was benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.tab_switching.typical_25 BUG=551405 ==========
Patchset #1 (id:1) has been deleted
nednguyen@google.com changed reviewers: + maruel@chromium.org
https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... File tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py (right): https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:91: return {} Fix is this line.
On 2015/11/05 18:36:43, nednguyen wrote: > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > File > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py > (right): > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:91: > return {} > Fix is this line. Marc: is there an easy way to request a build run with this patch apply on Mac10.9?
On 2015/11/05 19:18:24, nednguyen wrote: > On 2015/11/05 18:36:43, nednguyen wrote: > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > File > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py > > (right): > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:91: > > return {} > > Fix is this line. > > Marc: is there an easy way to request a build run with this patch apply on > Mac10.9? Retry a task that ran on the try builder. ./swarming.py trigger -S chromium-swarm.appspot.com -I isolateserver.appspot.com -d os Mac-10.9 --namespace default-gzip -T "Yo Dawg" -s <sha1ofisolatedinput>
On 2015/11/05 19:23:42, M-A Ruel wrote: > On 2015/11/05 19:18:24, nednguyen wrote: > > On 2015/11/05 18:36:43, nednguyen wrote: > > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > File > > > > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py > > > (right): > > > > > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:91: > > > return {} > > > Fix is this line. > > > > Marc: is there an easy way to request a build run with this patch apply on > > Mac10.9? > > Retry a task that ran on the try builder. > > ./swarming.py trigger -S http://chromium-swarm.appspot.com -I http://isolateserver.appspot.com > -d os Mac-10.9 --namespace default-gzip -T "Yo Dawg" -s <sha1ofisolatedinput> Thanks! Trigger the job on Mac10.9 here: https://chromium-swarm.appspot.com/user/task/2af1fad56cf6ac10
On 2015/11/05 19:40:20, nednguyen wrote: > On 2015/11/05 19:23:42, M-A Ruel wrote: > > On 2015/11/05 19:18:24, nednguyen wrote: > > > On 2015/11/05 18:36:43, nednguyen wrote: > > > > > > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > > File > > > > > > > > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py > > > > (right): > > > > > > > > > > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > > > > > > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:91: > > > > return {} > > > > Fix is this line. > > > > > > Marc: is there an easy way to request a build run with this patch apply on > > > Mac10.9? > > > > Retry a task that ran on the try builder. > > > > ./swarming.py trigger -S http://chromium-swarm.appspot.com -I > http://isolateserver.appspot.com > > -d os Mac-10.9 --namespace default-gzip -T "Yo Dawg" -s <sha1ofisolatedinput> > > Thanks! Trigger the job on Mac10.9 here: > https://chromium-swarm.appspot.com/user/task/2af1fad56cf6ac10 Did the original task you used as input had "extra args" ?
Description was changed from ========== [Telemetry] Check whether powermetrics service has already terminated and fail gracefully This is a reland of http://crrev.com/1410553009#ps40001 Last time the patch landed, the only failed test was benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.tab_switching.typical_25 BUG=551405 ========== to ========== [Telemetry] Check whether powermetrics service has already terminated and fail gracefully This is a reland of http://crrev.com/1410553009#ps40001 Last time the patch landed, the only failed test was benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.tab_switching.typical_25 The patch run succeeded on Mac10.9 swarming slave: https://chromium-swarm.appspot.com/user/task/2af23c6d3655e210 BUG=551405 ==========
On 2015/11/05 19:43:18, M-A Ruel wrote: > On 2015/11/05 19:40:20, nednguyen wrote: > > On 2015/11/05 19:23:42, M-A Ruel wrote: > > > On 2015/11/05 19:18:24, nednguyen wrote: > > > > On 2015/11/05 18:36:43, nednguyen wrote: > > > > > > > > > > > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > > > File > > > > > > > > > > > > > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py > > > > > (right): > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > > > > > > > > > > > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:91: > > > > > return {} > > > > > Fix is this line. > > > > > > > > Marc: is there an easy way to request a build run with this patch apply on > > > > Mac10.9? > > > > > > Retry a task that ran on the try builder. > > > > > > ./swarming.py trigger -S http://chromium-swarm.appspot.com -I > > http://isolateserver.appspot.com > > > -d os Mac-10.9 --namespace default-gzip -T "Yo Dawg" -s > <sha1ofisolatedinput> > > > > Thanks! Trigger the job on Mac10.9 here: > > https://chromium-swarm.appspot.com/user/task/2af1fad56cf6ac10 > > Did the original task you used as input had "extra args" ? Thanks Marc, I updated the description with the latest run. telemetry_perf_unittests is now passed on Mac10.9.
Description was changed from ========== [Telemetry] Check whether powermetrics service has already terminated and fail gracefully This is a reland of http://crrev.com/1410553009#ps40001 Last time the patch landed, the only failed test was benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.tab_switching.typical_25 The patch run succeeded on Mac10.9 swarming slave: https://chromium-swarm.appspot.com/user/task/2af23c6d3655e210 BUG=551405 ========== to ========== [Telemetry] Check whether powermetrics service has already terminated and fail gracefully This is a reland of http://crrev.com/1410553009#ps40001 Last time the patch landed, the only failed test was benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.tab_switching.typical_25 Patch run on Mac10.9 swarming slave: https://chromium-swarm.appspot.com/user/task/2af247b85b5f6610 BUG=551405 ==========
On 2015/11/05 20:58:30, nednguyen wrote: > On 2015/11/05 19:43:18, M-A Ruel wrote: > > On 2015/11/05 19:40:20, nednguyen wrote: > > > On 2015/11/05 19:23:42, M-A Ruel wrote: > > > > On 2015/11/05 19:18:24, nednguyen wrote: > > > > > On 2015/11/05 18:36:43, nednguyen wrote: > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > > > > File > > > > > > > > > > > > > > > > > > > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py > > > > > > (right): > > > > > > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/1431023002/diff/60001/tools/telemetry/telemet... > > > > > > > > > > > > > > > > > > > > > tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py:91: > > > > > > return {} > > > > > > Fix is this line. > > > > > > > > > > Marc: is there an easy way to request a build run with this patch apply > on > > > > > Mac10.9? > > > > > > > > Retry a task that ran on the try builder. > > > > > > > > ./swarming.py trigger -S http://chromium-swarm.appspot.com -I > > > http://isolateserver.appspot.com > > > > -d os Mac-10.9 --namespace default-gzip -T "Yo Dawg" -s > > <sha1ofisolatedinput> > > > > > > Thanks! Trigger the job on Mac10.9 here: > > > https://chromium-swarm.appspot.com/user/task/2af1fad56cf6ac10 > > > > Did the original task you used as input had "extra args" ? > > Thanks Marc, I updated the description with the latest run. > telemetry_perf_unittests is now passed on Mac10.9. https://chromium-swarm.appspot.com/user/task/2af247b85b5f6610 ? Good. lgtm
The CQ bit was checked by nednguyen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1431023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1431023002/60001
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/56bd9aa8be4606cf7d4c9aea5e76157c688a1ba3 Cr-Commit-Position: refs/heads/master@{#358193} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
