tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor_unittest.py - Issue 1431023002: [Telemetry] Check whether powermetrics service has already terminated and fail gracefully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor_unittest.py

Issue 1431023002: [Telemetry] Check whether powermetrics service has already terminated and fail gracefully (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py ('K') | « tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor_unittest.py

diff --git a/tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor_unittest.py b/tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor_unittest.py

index 25f5d11775865e92ee28e4e80ce474f5e9f9c65e..1c5a65cef129c172a09545a8af92cdfb03e76b87 100644

--- a/tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor_unittest.py

+++ b/tools/telemetry/telemetry/internal/platform/power_monitor/powermetrics_power_monitor_unittest.py

@@ -35,7 +35,7 @@ class PowerMetricsPowerMonitorTest(unittest.TestCase):

@decorators.Enabled('mac')

def testParseEmptyPowerMetricsOutput(self):

# Important to handle zero length powermetrics outout - crbug.com/353250 .

- self.assertIsNone(powermetrics_power_monitor.PowerMetricsPowerMonitor.

+ self.assertFalse(powermetrics_power_monitor.PowerMetricsPowerMonitor.

ParsePowerMetricsOutput(''))

@decorators.Enabled('mac')