Check field overrides

Check field overrides

Fixes https://github.com/dart-lang/dev_compiler/issues/52

This hits once in the SDK - naturally Devon hit it writing his version of hello world.  Fix coming in DDC.

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/19ff4ca2f76c220d30fce8605fc46111ed8279ff

[vsm, 2015-11-06 14:32:46]

Description was changed from

==========
Check field overrides

Fixes https://github.com/dart-lang/dev_compiler/issues/52

This hits once in the SDK - naturally Devon hit it writing his version of hello
world.
Fix coming.
==========

to

==========
Check field overrides

Fixes https://github.com/dart-lang/dev_compiler/issues/52

This hits once in the SDK - naturally Devon hit it writing his version of hello
world.  Fix coming in DDC.
==========

[vsm, 2015-11-06 14:32:47]

vsm@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com

[vsm, 2015-11-06 17:11:12]

On 2015/11/06 14:33:01, vsm wrote:

PTAL - extra test + fix for private members

[Leaf, 2015-11-06 21:08:36]

lgtm

https://codereview.chromium.org/1430953004/diff/1/pkg/analyzer/lib/src/task/s...
File pkg/analyzer/lib/src/task/strong/checker.dart (right):

https://codereview.chromium.org/1430953004/diff/1/pkg/analyzer/lib/src/task/s...
pkg/analyzer/lib/src/task/strong/checker.dart:308: // Disallow any overridding
if the base class defines this member
overriding

[vsm, 2015-11-06 22:04:55]

Committed patchset #4 (id:60001) manually as
19ff4ca2f76c220d30fce8605fc46111ed8279ff (presubmit successful).