Check field overrides

pkg/analyzer/test/src/task/strong/checker_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(jmesserly): this file needs to be refactored, it's a port from
 // package:dev_compiler's tests
 /// General type checking tests
 library test.src.task.strong.checker_test;
 
 import 'package:unittest/unittest.dart';
@@ skipping 1114 matching lines @@
           class C extends B {}
 
           class Base {
             B f1;
             B f2;
             B f3;
             B f4;
           }
 
           class Child extends Base {
+            /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/A f1; // invalid for getter
+            /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/C f2; // invalid for setter
+            /*severe:InvalidFieldOverride*/var f3;
+            /*severe:InvalidFieldOverride,severe:InvalidMethodOverride,severe:InvalidMethodOverride*/dynamic f4;
+          }
+
+          class Child2 implements Base {
             /*severe:InvalidMethodOverride*/A f1; // invalid for getter
             /*severe:InvalidMethodOverride*/C f2; // invalid for setter
             var f3;
             /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/dynamic f4;
           }
        '''
   });
 
+  testChecker('private override', {
+    '/helper.dart': '''
+          import 'main.dart' as main;
+
+          class Base {
+            var f1;
+            var _f2;
+            var _f3;
+            get _f4 => null;
+
+            int _m1();
+          }
+
+          class GrandChild extends main.Child {
+            /*severe:InvalidFieldOverride*/var _f2;
+            /*severe:InvalidFieldOverride*/var _f3;
+            var _f4;
+
+            /*severe:InvalidMethodOverride*/String _m1();
+          }
+    ''',
+    '/main.dart': '''
+          import 'helper.dart' as helper;
+
+          class Child extends helper.Base {
+            /*severe:InvalidFieldOverride*/var f1;
+            var _f2;
+            var _f4;
+
+            String _m1();
+          }
+    '''
+  });
+
   testChecker('getter/getter override', {
     '/main.dart': '''
           class A {}
           class B extends A {}
           class C extends B {}
 
           abstract class Base {
             B get f1;
             B get f2;
             B get f3;
@@ skipping 16 matching lines @@
           class C extends B {}
 
           abstract class Base {
             B f1;
             B f2;
             B f3;
             B f4;
           }
 
           class Child extends Base {
+            /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/A get f1 => null;
+            /*severe:InvalidFieldOverride*/C get f2 => null;
+            /*severe:InvalidFieldOverride*/get f3 => null;
+            /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/dynamic get f4 => null;
+          }
+
+          class Child2 implements Base {
             /*severe:InvalidMethodOverride*/A get f1 => null;
             C get f2 => null;
             get f3 => null;
             /*severe:InvalidMethodOverride*/dynamic get f4 => null;
           }
        '''
   });
 
   testChecker('setter/setter override', {
     '/main.dart': '''
@@ skipping 27 matching lines @@
 
           class Base {
             B f1;
             B f2;
             B f3;
             B f4;
             B f5;
           }
 
           class Child extends Base {
+            /*severe:InvalidFieldOverride*/B get f1 => null;
+            /*severe:InvalidFieldOverride*/B get f2 => null;
+            /*severe:InvalidFieldOverride*/B get f3 => null;
+            /*severe:InvalidFieldOverride*/B get f4 => null;
+            /*severe:InvalidFieldOverride*/B get f5 => null;
+
+            /*severe:InvalidFieldOverride*/void set f1(A value) {}
+            /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/void set f2(C value) {}
+            /*severe:InvalidFieldOverride*/void set f3(value) {}
+            /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/void set f4(dynamic value) {}
+            /*severe:InvalidFieldOverride*/set f5(B value) {}
+          }
+
+          class Child2 implements Base {
             B get f1 => null;
             B get f2 => null;
             B get f3 => null;
             B get f4 => null;
             B get f5 => null;
 
             void set f1(A value) {}
             /*severe:InvalidMethodOverride*/void set f2(C value) {}
             void set f3(value) {}
             /*severe:InvalidMethodOverride*/void set f4(dynamic value) {}
@@ skipping 265 matching lines @@
     testChecker('child override', {
       '/main.dart': '''
             class A {}
             class B {}
 
             class Base {
                 A f;
             }
 
             class T1 extends Base {
+              /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/B get f => null;
+            }
+
+            class T2 extends Base {
+              /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/set f(B b) => null;
+            }
+
+            class T3 extends Base {
+              /*severe:InvalidFieldOverride,severe:InvalidMethodOverride*/final B f;
+            }
+            class T4 extends Base {
+              // two: one for the getter one for the setter.
+              /*severe:InvalidFieldOverride,severe:InvalidMethodOverride,severe:InvalidMethodOverride*/B f;
+            }
+
+            class T5 implements Base {
               /*severe:InvalidMethodOverride*/B get f => null;
             }
 
-            class T2 extends Base {
+            class T6 implements Base {
               /*severe:InvalidMethodOverride*/set f(B b) => null;
             }
 
-            class T3 extends Base {
+            class T7 implements Base {
               /*severe:InvalidMethodOverride*/final B f;
             }
-            class T4 extends Base {
+            class T8 implements Base {
               // two: one for the getter one for the setter.
               /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/B f;
             }
          '''
     });
 
     testChecker('child override 2', {
       '/main.dart': '''
             class A {}
             class B {}
 
             class Base {
                 m(A a) {}
             }
 
             class Test extends Base {
                 /*severe:InvalidMethodOverride*/m(B a) {}
             }
          '''
     });
     testChecker('grandchild override', {
       '/main.dart': '''
             class A {}
             class B {}
 
             class Grandparent {
                 m(A a) {}
+                int x;
             }
             class Parent extends Grandparent {
             }
 
             class Test extends Parent {
                 /*severe:InvalidMethodOverride*/m(B a) {}
+                /*severe:InvalidFieldOverride*/int x;
             }
          '''
     });
 
     testChecker('double override', {
       '/main.dart': '''
             class A {}
             class B {}
 
             class Grandparent {
@@ skipping 28 matching lines @@
          '''
     });
 
     testChecker('mixin override to base', {
       '/main.dart': '''
             class A {}
             class B {}
 
             class Base {
                 m(A a) {}
+                int x;
             }
 
             class M1 {
                 m(B a) {}
             }
 
-            class M2 {}
+            class M2 {
+                int x;
+            }
 
             class T1 extends Base with /*severe:InvalidMethodOverride*/M1 {}
-            class T2 extends Base with /*severe:InvalidMethodOverride*/M1, M2 {}
-            class T3 extends Base with M2, /*severe:InvalidMethodOverride*/M1 {}
+            class T2 extends Base with /*severe:InvalidMethodOverride*/M1, /*severe:InvalidFieldOverride*/M2 {}
+            class T3 extends Base with /*severe:InvalidFieldOverride*/M2, /*severe:InvalidMethodOverride*/M1 {}
          '''
     });
 
     testChecker('mixin override to mixin', {
       '/main.dart': '''
             class A {}
             class B {}
 
             class Base {
             }
 
             class M1 {
                 m(B a) {}
+                int x;
             }
 
             class M2 {
                 m(A a) {}
+                int x;
             }
 
-            class T1 extends Base with M1, /*severe:InvalidMethodOverride*/M2 {}
+            class T1 extends Base with M1, /*severe:InvalidMethodOverride,severe:InvalidFieldOverride*/M2 {}
          '''
     });
 
     // This is a regression test for a bug in an earlier implementation were
     // names were hiding errors if the first mixin override looked correct,
     // but subsequent ones did not.
     testChecker('no duplicate mixin override', {
       '/main.dart': '''
             class A {}
             class B {}
@@ skipping 670 matching lines @@
 
         baz1() sync* { yield* (/*info:DynamicCast*/x); }
         Iterable baz2() sync* { yield* (/*info:DynamicCast*/x); }
         Iterable<int> baz3() sync* { yield* (/*warning:DownCastComposite*/x); }
         Iterable<int> baz4() sync* { yield* new Iterable<int>(); }
         Iterable<int> baz5() sync* { yield* (/*info:InferredTypeAllocation*/new Iterable()); }
     '''
     });
   });
 }