Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Issue 1430943002: X87: Change the test case for X87 float operations (Closed)

Created:
5 years, 1 month ago by chunyang.dai
Modified:
5 years, 1 month ago
Reviewers:
Weiliang, titzer, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Change the test case for X87 float operations The CL https://codereview.chromium.org/1409013004 added / changed some test cases. Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type case to keep the same precision. float expect = *i * *j; // *i + *j, etc. For test case "RunFloat64MulAndFloat64Add1 / RunFloat64MulAndFloat64Add2 / RunFloat64MulAndFloat64Sub1 / RunFloat64MulAndFloat64Sub2", the expected result calcaulated by GCC has difference precsion when comparing with V8 turbofan result for X87 platform. (Turbofan X87 result is the same as IA32 GCC and IA32 Turbofan). So we have to disable those four cases for X87 port. BUG= Committed: https://crrev.com/5736eb0ccbae38894cec7dd86633717d718a5eb7 Cr-Commit-Position: refs/heads/master@{#31808}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -8 lines) Patch
M test/cctest/cctest.status View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 8 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
chunyang.dai
PTAL.
5 years, 1 month ago (2015-11-03 14:52:35 UTC) #3
titzer
https://codereview.chromium.org/1430943002/diff/1/test/cctest/compiler/test-run-machops.cc File test/cctest/compiler/test-run-machops.cc (right): https://codereview.chromium.org/1430943002/diff/1/test/cctest/compiler/test-run-machops.cc#newcode3246 test/cctest/compiler/test-run-machops.cc:3246: float expected = *i + *j; These should probably ...
5 years, 1 month ago (2015-11-03 19:01:43 UTC) #4
chunyang.dai
Hi, Titizer. I updated it according to your suggestion. PTAL. thanks.
5 years, 1 month ago (2015-11-04 08:28:02 UTC) #5
titzer
lgtm
5 years, 1 month ago (2015-11-04 18:07:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430943002/20001
5 years, 1 month ago (2015-11-04 23:28:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 00:14:58 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 00:15:45 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5736eb0ccbae38894cec7dd86633717d718a5eb7
Cr-Commit-Position: refs/heads/master@{#31808}

Powered by Google App Engine
This is Rietveld 408576698