Issue 1409013004: Changed some tests to use the BufferedRawMachineAssemblerTester.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409013004: Changed some tests to use the BufferedRawMachineAssemblerTester. (Closed)

Created:
5 years, 1 month ago by ahaas

Modified:
5 years, 1 month ago

Reviewers:
ahaas1, titzer

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Changed some tests to use the BufferedRawMachineAssemblerTester. The BufferedRawMachineAssemblerTester takes care of storing and loading parameters to and from memory for these test cases. By using the BufferedRawMachineAssemblerTester the test cases become more readible. R=titzer@chromium.org Committed: https://crrev.com/a14dd158768c256347c11e726222114af068692c Cr-Commit-Position: refs/heads/master@{#31718}

Patch Set 1 #

Patch Set 2 : Fixed the value range of the test RunChangeFloat64ToInt32_B. #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -281 lines)			Patch
	M	test/cctest/compiler/test-run-machops.cc	View	1	5 chunks	+177 lines, -281 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409013004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409013004/20001

5 years, 1 month ago (2015-11-02 19:17:48 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-11-02 19:19:54 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/a14dd158768c256347c11e726222114af068692c
Cr-Commit-Position: refs/heads/master@{#31718}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages