Issue 1430803003: Merge to XFA: Clean up CPDF_AnnotList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1430803003: Merge to XFA: Clean up CPDF_AnnotList. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Clean up CPDF_AnnotList. - Remove dead code - Stop using CFX_PtrArray - Mark more things const - Fix style nits TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1425093003 . (cherry picked from commit c88c42f317c0e94c4c7b98949bfe1a495aef07a9) Committed: https://pdfium.googlesource.com/pdfium/+/1b700c3c452429dacde3c163a6edb2706f93d4a7

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -171 lines)			Patch
M	core/include/fpdfdoc/fpdf_doc.h	View		5 chunks	+13 lines, -48 lines	0 comments	Download
M	core/src/fpdfdoc/doc_annot.cpp	View		7 chunks	+46 lines, -74 lines	0 comments	Download
M	core/src/fpdfdoc/doc_form.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/include/fsdk_baseform.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/include/fsdk_define.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/include/fsdk_mgr.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/fpdf_ext.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	fpdfsdk/src/fpdfeditpage.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fsdk_baseform.cpp	View		1 chunk	+5 lines, -19 lines	0 comments	Download
M	fpdfsdk/src/fsdk_mgr.cpp	View	1	4 chunks	+12 lines, -20 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 1 month ago (2015-10-31 06:55:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1b700c3c452429dacde3c163a6edb2706f93d4a7 (presubmit successful).