Clean up CPDF_AnnotList.

Clean up CPDF_AnnotList.

- Remove dead code
- Stop using CFX_PtrArray
- Mark more things const
- Fix style nits

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/c88c42f317c0e94c4c7b98949bfe1a495aef07a9

[Lei Zhang, 2015-10-30 20:11:21]

Description was changed from

==========
Clean up CPDF_AnnotList.

- Remove dead code
- Stop using CFX_PtrArray
- Fix style nits
==========

to

==========
Clean up CPDF_AnnotList.

- Remove dead code
- Stop using CFX_PtrArray
- Mark more things const
- Fix style nits
==========

[Lei Zhang, 2015-10-30 20:11:21]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-10-30 20:26:07]

https://codereview.chromium.org/1425093003/diff/60001/core/include/fpdfdoc/fp...
File core/include/fpdfdoc/fpdf_doc.h (right):

https://codereview.chromium.org/1425093003/diff/60001/core/include/fpdfdoc/fp...
core/include/fpdfdoc/fpdf_doc.h:452: CPDF_Annot* GetAt(size_t index) { return
m_AnnotList[index]; }
Is this a const method, too?

https://codereview.chromium.org/1425093003/diff/60001/core/src/fpdfdoc/doc_an...
File core/src/fpdfdoc/doc_annot.cpp (right):

https://codereview.chromium.org/1425093003/diff/60001/core/src/fpdfdoc/doc_an...
core/src/fpdfdoc/doc_annot.cpp:152: const CPDF_Dictionary*
CPDF_Annot::GetAnnotDict() const {
This should be in the class declaration itself?

https://codereview.chromium.org/1425093003/diff/60001/core/src/fpdfdoc/doc_an...
core/src/fpdfdoc/doc_annot.cpp:203: void* pForm;
thank you!!!

https://codereview.chromium.org/1425093003/diff/60001/fpdfsdk/src/fsdk_basefo...
File fpdfsdk/src/fsdk_baseform.cpp (right):

https://codereview.chromium.org/1425093003/diff/60001/fpdfsdk/src/fsdk_basefo...
fpdfsdk/src/fsdk_baseform.cpp:104: CPDF_FormControl* pCtrl = GetFormControl();
I thought I'd collapsed a bunch of these into:

  return GetFormControl()->GetField();

https://codereview.chromium.org/1425093003/diff/60001/fpdfsdk/src/fsdk_mgr.cpp
File fpdfsdk/src/fsdk_mgr.cpp (right):

https://codereview.chromium.org/1425093003/diff/60001/fpdfsdk/src/fsdk_mgr.cp...
fpdfsdk/src/fsdk_mgr.cpp:947: for (const CPDF_Annot* pAnnot :
m_pAnnotList->All()) {
Use std::find() rather than explicit iteration.

[Lei Zhang, 2015-10-30 22:17:51]

https://codereview.chromium.org/1425093003/diff/60001/core/include/fpdfdoc/fp...
File core/include/fpdfdoc/fpdf_doc.h (right):

https://codereview.chromium.org/1425093003/diff/60001/core/include/fpdfdoc/fp...
core/include/fpdfdoc/fpdf_doc.h:452: CPDF_Annot* GetAt(size_t index) { return
m_AnnotList[index]; }
On 2015/10/30 20:26:06, Tom Sepez wrote:
> Is this a const method, too?

Done.

https://codereview.chromium.org/1425093003/diff/60001/core/src/fpdfdoc/doc_an...
File core/src/fpdfdoc/doc_annot.cpp (right):

https://codereview.chromium.org/1425093003/diff/60001/core/src/fpdfdoc/doc_an...
core/src/fpdfdoc/doc_annot.cpp:152: const CPDF_Dictionary*
CPDF_Annot::GetAnnotDict() const {
On 2015/10/30 20:26:06, Tom Sepez wrote:
> This should be in the class declaration itself?

Done.

https://codereview.chromium.org/1425093003/diff/60001/core/src/fpdfdoc/doc_an...
core/src/fpdfdoc/doc_annot.cpp:203: void* pForm;
On 2015/10/30 20:26:06, Tom Sepez wrote:
> thank you!!!

Acknowledged.

https://codereview.chromium.org/1425093003/diff/60001/fpdfsdk/src/fsdk_basefo...
File fpdfsdk/src/fsdk_baseform.cpp (right):

https://codereview.chromium.org/1425093003/diff/60001/fpdfsdk/src/fsdk_basefo...
fpdfsdk/src/fsdk_baseform.cpp:104: CPDF_FormControl* pCtrl = GetFormControl();
On 2015/10/30 20:26:07, Tom Sepez wrote:
> I thought I'd collapsed a bunch of these into:
> 
>   return GetFormControl()->GetField();

Done.

https://codereview.chromium.org/1425093003/diff/60001/fpdfsdk/src/fsdk_mgr.cpp
File fpdfsdk/src/fsdk_mgr.cpp (right):

https://codereview.chromium.org/1425093003/diff/60001/fpdfsdk/src/fsdk_mgr.cp...
fpdfsdk/src/fsdk_mgr.cpp:947: for (const CPDF_Annot* pAnnot :
m_pAnnotList->All()) {
On 2015/10/30 20:26:07, Tom Sepez wrote:
> Use std::find() rather than explicit iteration.

Done.

[Tom Sepez, 2015-10-30 22:23:32]

lgtm

[Lei Zhang, 2015-10-31 06:42:42]

Committed patchset #6 (id:100001) manually as
c88c42f317c0e94c4c7b98949bfe1a495aef07a9 (presubmit successful).