gpu/command_buffer/service/texture_manager.h - Issue 14308014: Clean up of GLES2 Command Decoder by moving some of the error state into a separate class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_manager.h

Issue 14308014: Clean up of GLES2 Command Decoder by moving some of the error state into a separate class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the remaining tests. Added mock ErrorState. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/test_helper.cc ('k') | gpu/command_buffer/service/texture_manager.cc » ('j') | gpu/command_buffer/service/vertex_attrib_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/texture_manager.h

diff --git a/gpu/command_buffer/service/texture_manager.h b/gpu/command_buffer/service/texture_manager.h

index 2efd6a940483b912a7a45748ef1c6e6214009ac8..30bdb784c109e546f11ed0b846ac410ceb6e61b9 100644

--- a/gpu/command_buffer/service/texture_manager.h

+++ b/gpu/command_buffer/service/texture_manager.h

@@ -23,6 +23,7 @@ namespace gles2 {

class GLES2Decoder;

class Display;

+class ErrorState;

class FeatureInfo;

class TextureDefinition;

class TextureManager;

@@ -477,7 +478,7 @@ class GPU_EXPORT TextureManager {

// Returns GL_NO_ERROR on success. Otherwise the error to generate.

// TODO(gman): Expand to SetParameteri,f,iv,fv

void SetParameter(

- const char* function_name, GLES2Decoder* decoder,

+ const char* function_name, ErrorState* error_state,

Texture* texture, GLenum pname, GLint param);

// Makes each of the mip levels as though they were generated.