gpu/command_buffer/service/test_helper.h - Issue 14308014: Clean up of GLES2 Command Decoder by moving some of the error state into a separate class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/test_helper.h

Issue 14308014: Clean up of GLES2 Command Decoder by moving some of the error state into a separate class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the remaining tests. Added mock ErrorState. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/query_manager_unittest.cc ('k') | gpu/command_buffer/service/test_helper.cc » ('j') | gpu/command_buffer/service/vertex_attrib_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/test_helper.h

diff --git a/gpu/command_buffer/service/test_helper.h b/gpu/command_buffer/service/test_helper.h

index d04e9bddcc8e4802c67c5f5d6da5c9a4b52f97d4..41cb3aa1b27c80c3bedd2ee7f5a9dfaa3725f750 100644

--- a/gpu/command_buffer/service/test_helper.h

+++ b/gpu/command_buffer/service/test_helper.h

@@ -14,7 +14,7 @@ namespace gles2 {

struct DisallowedFeatures;

class Buffer;

class BufferManager;

-class MockGLES2Decoder;

+class MockErrorState;

class Texture;

class TextureManager;

@@ -92,12 +92,12 @@ class TestHelper {

GLuint service_id);

static void DoBufferData(

- ::gfx::MockGLInterface* gl, MockGLES2Decoder* decoder,

+ ::gfx::MockGLInterface* gl, MockErrorState* error_state,

BufferManager* manager, Buffer* buffer, GLsizeiptr size, GLenum usage,

const GLvoid* data, GLenum error);

static void SetTexParameterWithExpectations(

- ::gfx::MockGLInterface* gl, MockGLES2Decoder* decoder,

+ ::gfx::MockGLInterface* gl, MockErrorState* error_state,

TextureManager* manager, Texture* texture,

GLenum pname, GLint value, GLenum error);