build/android/pylib/local/device/local_device_environment.py - Issue 1430663002: specify the reason for blacklisting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/local/device/local_device_environment.py

Issue 1430663002: specify the reason for blacklisting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add reason for local device failures Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/local/device/local_device_environment.py

diff --git a/build/android/pylib/local/device/local_device_environment.py b/build/android/pylib/local/device/local_device_environment.py

index 4fdfbdff9b8e4cb8649db6406b74cfa7bfd600f7..7d9651e4366c22d4b17ca84a54e45eb3e9a59269 100644

--- a/build/android/pylib/local/device/local_device_environment.py

+++ b/build/android/pylib/local/device/local_device_environment.py

@@ -96,7 +96,7 @@ class LocalDeviceEnvironment(environment.Environment):

f.write(d.DumpCacheData())

logging.info('Wrote device cache: %s', cache_path)

- def BlacklistDevice(self, device):

+ def BlacklistDevice(self, device, reason='local_device_failure'):

if not self._blacklist:

logging.warning(

'Attempted to blacklist %s, but no blacklist was provided.',

@@ -104,7 +104,7 @@ class LocalDeviceEnvironment(environment.Environment):

return

device_serial = device.adb.GetDeviceSerial()

- self._blacklist.Extend([device_serial])

+ self._blacklist.Extend([device_serial], reason=reason)

with self._devices_lock:

self._devices = [d for d in self._devices if str(d) != device_serial]