build/android/provision_devices.py - Issue 1430663002: specify the reason for blacklisting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/provision_devices.py

Issue 1430663002: specify the reason for blacklisting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add reason for local device failures Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/provision_devices.py

diff --git a/build/android/provision_devices.py b/build/android/provision_devices.py

index 39c3095083e6f57d6e30f71ba1b401cb3cdbf612..624e157d296a4544b78ff35b16145f3651c68fcf 100755

--- a/build/android/provision_devices.py

+++ b/build/android/provision_devices.py

@@ -122,12 +122,12 @@ def ProvisionDevice(device, blacklist, options):

except device_errors.CommandTimeoutError:

logging.exception('Timed out waiting for device %s. Adding to blacklist.',

str(device))

- blacklist.Extend([str(device)])

+ blacklist.Extend([str(device)], reason='provision_timeout')

except device_errors.CommandFailedError:

logging.exception('Failed to provision device %s. Adding to blacklist.',

str(device))

- blacklist.Extend([str(device)])

+ blacklist.Extend([str(device)], reason='provision_failure')

def CheckExternalStorage(device):

"""Checks that storage is writable and if not makes it writable.