Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1430593006: Simplify SkGpuBlurUtils. (Closed)

Created:
5 years, 1 month ago by Stephen White
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify SkGpuBlurUtils. We compute a lot of { srcRect, dstRect } pairs in this code, but they're always the same width and height, and dstRect often has a zero origin. So pass only one or the other and an offset, where required. Among other things, this simplifies the code in convolve_gaussian(), since we only have to 3-patch the dstRect. BUG=skia:4502 Committed: https://skia.googlesource.com/skia/+/48343eea6f40a523306069e917ed9a1d6c39434c

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : More cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -31 lines) Patch
M src/effects/SkGpuBlurUtils.cpp View 1 2 7 chunks +24 lines, -31 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 1 month ago (2015-11-02 17:52:09 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430593006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430593006/40001
5 years, 1 month ago (2015-11-02 17:53:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 18:04:10 UTC) #7
bsalomon
lgtm
5 years, 1 month ago (2015-11-02 19:10:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430593006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430593006/40001
5 years, 1 month ago (2015-11-03 13:07:08 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 13:07:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/48343eea6f40a523306069e917ed9a1d6c39434c

Powered by Google App Engine
This is Rietveld 408576698