Simplify SkGpuBlurUtils.

src/effects/SkGpuBlurUtils.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkGpuBlurUtils.h"
 
 #include "SkRect.h"
@@ skipping 29 matching lines @@
             sigma = MAX_BLUR_SIGMA;
         }
     }
     *radius = static_cast<int>(ceilf(sigma * 3.0f));
     SkASSERT(*radius <= GrConvolutionEffect::kMaxKernelRadius);
     return sigma;
 }
 
 static void convolve_gaussian_1d(GrDrawContext* drawContext,
                                  const GrClip& clip,
-                                 const SkRect& srcRect,
                                  const SkRect& dstRect,
+                                 const SkPoint& srcOffset,
                                  GrTexture* texture,
                                  Gr1DKernelEffect::Direction direction,
                                  int radius,
                                  float sigma,
                                  bool useBounds,
                                  float bounds[2]) {
     GrPaint paint;
     SkAutoTUnref<GrFragmentProcessor> conv(GrConvolutionEffect::CreateGaussian(
         texture, direction, radius, sigma, useBounds, bounds));
     paint.addColorFragmentProcessor(conv);
-    drawContext->drawNonAARectToRect(clip, paint, SkMatrix::I(), dstRect, srcRect);
+    SkMatrix localMatrix = SkMatrix::MakeTrans(srcOffset.x(), srcOffset.y());
+    drawContext->drawNonAARectWithLocalMatrix(clip, paint, SkMatrix::I(), dstRect, localMatrix);
 }
 
 static void convolve_gaussian_2d(GrDrawContext* drawContext,
                                  const GrClip& clip,
                                  const SkRect& srcRect,
-                                 const SkRect& dstRect,
                                  GrTexture* texture,
                                  int radiusX,
                                  int radiusY,
                                  SkScalar sigmaX,
                                  SkScalar sigmaY,
                                  bool useBounds,
                                  SkIRect bounds) {
+    SkRect dstRect = SkRect::MakeWH(srcRect.width(), srcRect.height());
+    SkMatrix localMatrix = SkMatrix::MakeTrans(srcRect.x(), srcRect.y());
     SkISize size = SkISize::Make(2 * radiusX + 1,  2 * radiusY + 1);
     SkIPoint kernelOffset = SkIPoint::Make(radiusX, radiusY);
     GrPaint paint;
     SkAutoTUnref<GrFragmentProcessor> conv(GrMatrixConvolutionEffect::CreateGaussian(
             texture, bounds, size, 1.0, 0.0, kernelOffset,
             useBounds ? GrTextureDomain::kClamp_Mode : GrTextureDomain::kIgnore_Mode,
             true, sigmaX, sigmaY));
     paint.addColorFragmentProcessor(conv);
-    drawContext->drawNonAARectToRect(clip, paint, SkMatrix::I(), dstRect, srcRect);
+    drawContext->drawNonAARectWithLocalMatrix(clip, paint, SkMatrix::I(), dstRect, localMatrix);
 }
 
 static void convolve_gaussian(GrDrawContext* drawContext,
                               const GrClip& clip,
                               const SkRect& srcRect,
-                              const SkRect& dstRect,
                               GrTexture* texture,
                               Gr1DKernelEffect::Direction direction,
                               int radius,
                               float sigma,
                               bool cropToSrcRect) {
     float bounds[2] = { 0.0f, 1.0f };
+    SkRect dstRect = SkRect::MakeWH(srcRect.width(), srcRect.height());
+    SkPoint srcOffset = SkPoint::Make(srcRect.x(), srcRect.y());
     if (!cropToSrcRect) {
-        convolve_gaussian_1d(drawContext, clip, srcRect, dstRect, texture,
+        convolve_gaussian_1d(drawContext, clip, dstRect, srcOffset, texture,
                              direction, radius, sigma, false, bounds);
         return;
     }
-    SkRect lowerSrcRect = srcRect, lowerDstRect = dstRect;
-    SkRect middleSrcRect = srcRect, middleDstRect = dstRect;
-    SkRect upperSrcRect = srcRect, upperDstRect = dstRect;
+    SkRect lowerDstRect = dstRect;
+    SkRect middleDstRect = dstRect;
+    SkRect upperDstRect = dstRect;
     SkScalar size;
     SkScalar rad = SkIntToScalar(radius);
     if (direction == Gr1DKernelEffect::kX_Direction) {
         bounds[0] = SkScalarToFloat(srcRect.left()) / texture->width();
         bounds[1] = SkScalarToFloat(srcRect.right()) / texture->width();
-        size = srcRect.width();
-        lowerSrcRect.fRight = srcRect.left() + rad;
+        size = dstRect.width();
         lowerDstRect.fRight = dstRect.left() + rad;
-        upperSrcRect.fLeft = srcRect.right() - rad;
         upperDstRect.fLeft = dstRect.right() - rad;
-        middleSrcRect.inset(rad, 0);
         middleDstRect.inset(rad, 0);
     } else {
         bounds[0] = SkScalarToFloat(srcRect.top()) / texture->height();
         bounds[1] = SkScalarToFloat(srcRect.bottom()) / texture->height();
-        size = srcRect.height();
-        lowerSrcRect.fBottom = srcRect.top() + rad;
+        size = dstRect.height();
         lowerDstRect.fBottom = dstRect.top() + rad;
-        upperSrcRect.fTop = srcRect.bottom() - rad;
         upperDstRect.fTop = dstRect.bottom() - rad;
-        middleSrcRect.inset(0, rad);
         middleDstRect.inset(0, rad);
     }
     if (radius >= size * SK_ScalarHalf) {
         // Blur radius covers srcRect; use bounds over entire draw
-        convolve_gaussian_1d(drawContext, clip, srcRect, dstRect, texture,
+        convolve_gaussian_1d(drawContext, clip, dstRect, srcOffset, texture,
                             direction, radius, sigma, true, bounds);
     } else {
         // Draw upper and lower margins with bounds; middle without.
-        convolve_gaussian_1d(drawContext, clip, lowerSrcRect, lowerDstRect, texture,
+        convolve_gaussian_1d(drawContext, clip, lowerDstRect, srcOffset, texture,
                              direction, radius, sigma, true, bounds);
-        convolve_gaussian_1d(drawContext, clip, upperSrcRect, upperDstRect, texture,
+        convolve_gaussian_1d(drawContext, clip, upperDstRect, srcOffset, texture,
                              direction, radius, sigma, true, bounds);
-        convolve_gaussian_1d(drawContext, clip, middleSrcRect, middleDstRect, texture,
+        convolve_gaussian_1d(drawContext, clip, middleDstRect, srcOffset, texture,
                              direction, radius, sigma, false, bounds);
     }
 }
 
 GrTexture* GaussianBlur(GrContext* context,
                         GrTexture* srcTexture,
                         bool canClobberSrc,
                         const SkRect& rect,
                         bool cropToRect,
                         float sigmaX,
@@ skipping 85 matching lines @@
     }
 
     const SkIRect srcIRect = srcRect.roundOut();
 
     // For really small blurs (certainly no wider than 5x5 on desktop gpus) it is faster to just
     // launch a single non separable kernel vs two launches
     if (sigmaX > 0.0f && sigmaY > 0.0f &&
             (2 * radiusX + 1) * (2 * radiusY + 1) <= MAX_KERNEL_SIZE) {
         // We shouldn't be scaling because this is a small size blur
         SkASSERT((1 == scaleFactorX) && (1 == scaleFactorY));
-        SkRect dstRect = SkRect::MakeWH(srcRect.width(), srcRect.height());
 
         SkAutoTUnref<GrDrawContext> dstDrawContext(
                                              context->drawContext(dstTexture->asRenderTarget()));
         if (!dstDrawContext) {
             return nullptr;
         }
-        convolve_gaussian_2d(dstDrawContext, clip, srcRect, dstRect,
+        convolve_gaussian_2d(dstDrawContext, clip, srcRect,
                              srcTexture, radiusX, radiusY, sigmaX, sigmaY, cropToRect, srcIRect);
 
         srcDrawContext.swap(dstDrawContext);
-        srcRect = dstRect;
+        srcRect.offsetTo(0, 0);
         srcTexture = dstTexture;
         SkTSwap(dstTexture, tempTexture);
 
     } else {
         if (sigmaX > 0.0f) {
             if (scaleFactorX > 1) {
                 // TODO: if we pass in the source draw context we don't need this here
                 if (!srcDrawContext) {
                     srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
                     if (!srcDrawContext) {
                         return nullptr;
                     }        
                 }
 
                 // Clear out a radius to the right of the srcRect to prevent the
                 // X convolution from reading garbage.
                 clearRect = SkIRect::MakeXYWH(srcIRect.fRight, srcIRect.fTop,
                                               radiusX, srcIRect.height());
                 srcDrawContext->clear(&clearRect, 0x0, false);
             }
-            SkRect dstRect = SkRect::MakeWH(srcRect.width(), srcRect.height());
 
             SkAutoTUnref<GrDrawContext> dstDrawContext(
                                              context->drawContext(dstTexture->asRenderTarget()));
             if (!dstDrawContext) {
                 return nullptr;
             }
-            convolve_gaussian(dstDrawContext, clip, srcRect, dstRect,
+            convolve_gaussian(dstDrawContext, clip, srcRect,
                               srcTexture, Gr1DKernelEffect::kX_Direction, radiusX, sigmaX,
                               cropToRect);
 
             srcDrawContext.swap(dstDrawContext);
             srcTexture = dstTexture;
-            srcRect = dstRect;
+            srcRect.offsetTo(0, 0);
             SkTSwap(dstTexture, tempTexture);
         }
 
         if (sigmaY > 0.0f) {
             if (scaleFactorY > 1 || sigmaX > 0.0f) {
                 // TODO: if we pass in the source draw context we don't need this here
                 if (!srcDrawContext) {
                     srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
                     if (!srcDrawContext) {
                         return nullptr;
                     }        
                 }
 
                 // Clear out a radius below the srcRect to prevent the Y
                 // convolution from reading garbage.
                 clearRect = SkIRect::MakeXYWH(srcIRect.fLeft, srcIRect.fBottom,
                                               srcIRect.width(), radiusY);
                 srcDrawContext->clear(&clearRect, 0x0, false);
             }
 
-            SkRect dstRect = SkRect::MakeWH(srcRect.width(), srcRect.height());
-
             SkAutoTUnref<GrDrawContext> dstDrawContext(
                                                context->drawContext(dstTexture->asRenderTarget()));
             if (!dstDrawContext) {
                 return nullptr;
             }
             convolve_gaussian(dstDrawContext, clip, srcRect,
-                              dstRect, srcTexture, Gr1DKernelEffect::kY_Direction, radiusY, sigmaY,
+                              srcTexture, Gr1DKernelEffect::kY_Direction, radiusY, sigmaY,
                               cropToRect);
 
             srcDrawContext.swap(dstDrawContext);
             srcTexture = dstTexture;
-            srcRect = dstRect;
+            srcRect.offsetTo(0, 0);
             SkTSwap(dstTexture, tempTexture);
         }
     }
 
     if (scaleFactorX > 1 || scaleFactorY > 1) {
         SkASSERT(srcDrawContext);
 
         // Clear one pixel to the right and below, to accommodate bilinear
         // upsampling.
         clearRect = SkIRect::MakeXYWH(srcIRect.fLeft, srcIRect.fBottom,
@@ skipping 24 matching lines @@
         srcRect = dstRect;
         srcTexture = dstTexture;
         SkTSwap(dstTexture, tempTexture);
     }
 
     return SkRef(srcTexture);
 }
 #endif
 
 }