Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1430573009: Set optional LastSwiftUpdateCheck to Xcode project attributes. (Closed)

Created:
5 years, 1 month ago by altse1
Modified:
5 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com, aharper
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Set optional LastSwiftUpdateCheck to Xcode project attributes. Adding this to also supress project upgrade warnings for Swift-based gyp generated project files. R=mark@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/ae2d73840216529adeef06ecc21c958c47530542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pylib/gyp/generator/xcode.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
altse1
5 years, 1 month ago (2015-11-01 16:29:51 UTC) #3
Mark Mentovai
LGTM, I guess. I don’t know what this does.
5 years, 1 month ago (2015-11-01 16:30:47 UTC) #4
altse1
On 2015/11/01 16:30:47, Mark Mentovai wrote: > LGTM, I guess. I don’t know what this ...
5 years, 1 month ago (2015-11-01 18:54:25 UTC) #5
altse
On 2015/11/01 18:54:25, altse1 wrote: > On 2015/11/01 16:30:47, Mark Mentovai wrote: > > LGTM, ...
5 years, 1 month ago (2015-11-03 14:46:34 UTC) #6
Mark Mentovai
Committed patchset #1 (id:1) manually as ae2d73840216529adeef06ecc21c958c47530542 (presubmit successful).
5 years, 1 month ago (2015-11-03 14:49:55 UTC) #7
Mark Mentovai
GYP doesn’t have a commit queue, so I landed it for you.
5 years, 1 month ago (2015-11-03 14:52:02 UTC) #8
altse
5 years, 1 month ago (2015-11-03 15:06:17 UTC) #9
Message was sent while issue was closed.
On 2015/11/03 14:52:02, Mark Mentovai wrote:
> GYP doesn’t have a commit queue, so I landed it for you.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698