Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Side by Side Diff: pylib/gyp/generator/xcode.py

Issue 1430573009: Set optional LastSwiftUpdateCheck to Xcode project attributes. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 Google Inc. All rights reserved. 1 # Copyright (c) 2012 Google Inc. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import filecmp 5 import filecmp
6 import gyp.common 6 import gyp.common
7 import gyp.xcodeproj_file 7 import gyp.xcodeproj_file
8 import gyp.xcode_ninja 8 import gyp.xcode_ninja
9 import errno 9 import errno
10 import os 10 import os
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 pbxp = xcp.project 615 pbxp = xcp.project
616 616
617 # Set project-level attributes from multiple options 617 # Set project-level attributes from multiple options
618 project_attributes = {}; 618 project_attributes = {};
619 if parallel_builds: 619 if parallel_builds:
620 project_attributes['BuildIndependentTargetsInParallel'] = 'YES' 620 project_attributes['BuildIndependentTargetsInParallel'] = 'YES'
621 if upgrade_check_project_version: 621 if upgrade_check_project_version:
622 project_attributes['LastUpgradeCheck'] = upgrade_check_project_version 622 project_attributes['LastUpgradeCheck'] = upgrade_check_project_version
623 project_attributes['LastTestingUpgradeCheck'] = \ 623 project_attributes['LastTestingUpgradeCheck'] = \
624 upgrade_check_project_version 624 upgrade_check_project_version
625 project_attributes['LastSwiftUpdateCheck'] = \
626 upgrade_check_project_version
625 pbxp.SetProperty('attributes', project_attributes) 627 pbxp.SetProperty('attributes', project_attributes)
626 628
627 if project_version: 629 if project_version:
628 xcp.project_file.SetXcodeVersion(project_version) 630 xcp.project_file.SetXcodeVersion(project_version)
629 631
630 # Add gyp/gypi files to project 632 # Add gyp/gypi files to project
631 if not generator_flags.get('standalone'): 633 if not generator_flags.get('standalone'):
632 main_group = pbxp.GetProperty('mainGroup') 634 main_group = pbxp.GetProperty('mainGroup')
633 build_group = gyp.xcodeproj_file.PBXGroup({'name': 'Build'}) 635 build_group = gyp.xcodeproj_file.PBXGroup({'name': 'Build'})
634 main_group.AppendChild(build_group) 636 main_group.AppendChild(build_group)
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
1268 1270
1269 for build_file in build_files: 1271 for build_file in build_files:
1270 xcode_projects[build_file].Finalize1(xcode_targets, serialize_all_tests) 1272 xcode_projects[build_file].Finalize1(xcode_targets, serialize_all_tests)
1271 1273
1272 for build_file in build_files: 1274 for build_file in build_files:
1273 xcode_projects[build_file].Finalize2(xcode_targets, 1275 xcode_projects[build_file].Finalize2(xcode_targets,
1274 xcode_target_to_target_dict) 1276 xcode_target_to_target_dict)
1275 1277
1276 for build_file in build_files: 1278 for build_file in build_files:
1277 xcode_projects[build_file].Write() 1279 xcode_projects[build_file].Write()
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698