Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1430553004: Correctly align tab and toolbar backgrounds with the frame background. (Closed)

Created:
5 years, 1 month ago by Peter Kasting
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly align tab and toolbar backgrounds with the frame background. This fixes off-by-two/off-by-three errors in vertical positioning for themes that tried to provide aligned tab/toolbar and frame assets. Tested with several such themes, including both themes that did and did not provide a custom background tab image. BUG=none TEST=Apply the "Dots" theme from the webstore and open a restored-mode window; the alignment of the background images in the frame, background tabs, and foreground tab should all match. Committed: https://crrev.com/4942cf0a5685c6db69ef9f3b94b56bb9a36fa561 Cr-Commit-Position: refs/heads/master@{#358431}

Patch Set 1 #

Patch Set 2 : Fix errors, better comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 4 chunks +15 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Peter Kasting
5 years, 1 month ago (2015-11-05 20:52:51 UTC) #2
sky
LGTM
5 years, 1 month ago (2015-11-06 16:44:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430553004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430553004/20001
5 years, 1 month ago (2015-11-06 22:05:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-06 22:40:56 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 22:41:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4942cf0a5685c6db69ef9f3b94b56bb9a36fa561
Cr-Commit-Position: refs/heads/master@{#358431}

Powered by Google App Engine
This is Rietveld 408576698