Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: snapshot/win/process_reader_win.cc

Issue 1430523002: win: Disable some more warnings when not building with Crashpad's common.gypi (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: don't need to disable 4706 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/simple_string_dictionary_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/process_reader_win.cc
diff --git a/snapshot/win/process_reader_win.cc b/snapshot/win/process_reader_win.cc
index a10588862f299d1c621307586f56e80d15b9a433..373124d61930f04e3fed8c82f6f0735362eaef7f 100644
--- a/snapshot/win/process_reader_win.cc
+++ b/snapshot/win/process_reader_win.cc
@@ -86,10 +86,13 @@ process_types::SYSTEM_PROCESS_INFORMATION<Traits>* GetProcessInformation(
reinterpret_cast<process_types::SYSTEM_PROCESS_INFORMATION<Traits>*>(
buffer->get());
DWORD process_id = GetProcessId(process_handle);
- do {
+ for (;;) {
if (process->UniqueProcessId == process_id)
return process;
- } while (process = NextProcess(process));
+ process = NextProcess(process);
+ if (!process)
+ break;
+ }
LOG(ERROR) << "process " << process_id << " not found";
return nullptr;
« no previous file with comments | « client/simple_string_dictionary_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698