client/simple_string_dictionary_test.cc - Issue 1430523002: win: Disable some more warnings when not building with Crashpad's common.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/simple_string_dictionary_test.cc

Issue 1430523002: win: Disable some more warnings when not building with Crashpad's common.gypi (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: don't need to disable 4706 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: client/simple_string_dictionary_test.cc

diff --git a/client/simple_string_dictionary_test.cc b/client/simple_string_dictionary_test.cc

index 4619be742bf87bea84f8c24368c917707b045663..6396c2fe809c8b7da44f44c9705ddea1db12ffdb 100644

--- a/client/simple_string_dictionary_test.cc

+++ b/client/simple_string_dictionary_test.cc

@@ -172,8 +172,10 @@ TEST(SimpleStringDictionary, Iterator) {

int totalCount = 0;

- const SimpleStringDictionary::Entry* entry;

- while ((entry = iter.Next())) {

+ for (;;) {

+ const SimpleStringDictionary::Entry* entry = iter.Next();

+ if (!entry)

+ break;

totalCount++;

// Extract keyNumber from a string of the form key<keyNumber>

« no previous file with comments | « build/crashpad.gypi ('k') | snapshot/win/process_reader_win.cc » ('j') | no next file with comments »