win: Disable some more warnings when not building with Crashpad's common.gypi

win: Disable more warnings when not building with Crashpad's common.gypi

Roll mini_chromium deps to remove disabling of those warnings in common.gypi:
  8e12d3d win: Remove disabling some warnings

R=mark@chromium.org
BUG=chromium:546288, crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ba0e7de07b01490348e6f00dbbca47f312dd6f4a

[scottmg, 2015-10-27 20:15:22]

These don't leak out to client, but since's Chrome's building everything, that
doesn't really matter either way. I guess mini_chromium's build/common.gypi
should really match-or-be-more-strict-than Chromium's as it's sort of part of
the "API".

[scottmg, 2015-10-27 21:31:12]

With the updates in ps#2 we can remove the ones in
https://codereview.chromium.org/1419953006.

[Mark Mentovai, 2015-10-27 22:06:29]

LGTM, although this shows up in so many places that it may just be worth doing
it in crashpad.gypi.

[scottmg, 2015-10-27 22:08:10]

On 2015/10/27 22:06:29, Mark Mentovai wrote:
> LGTM, although this shows up in so many places that it may just be worth doing
> it in crashpad.gypi.

Maybe that's better... I'll put all 3 in there then?

[Mark Mentovai, 2015-10-27 22:10:25]

Yeah, I imagine that all three make sense for us globally.

[scottmg, 2015-10-27 22:13:35]

OK, moved to crashpad.gypi and included the DEPS roll.

[scottmg, 2015-10-27 22:14:08]

Description was changed from

==========
win: Disable more warnings when not building with Crashpad's common.gypi

R=mark@chromium.org
BUG=chromium:546288, crashpad:1
==========

to

==========
win: Disable more warnings when not building with Crashpad's common.gypi

Roll mini_chromium deps to remove disabling of those warnings in common.gypi:
  8e12d3d win: Remove disabling some warnings

R=mark@chromium.org
BUG=chromium:546288, crashpad:1
==========

[Mark Mentovai, 2015-10-27 22:21:57]

LGTM.

Well, I'm a little less positive about 4706. Where did that one show up?

[scottmg, 2015-10-27 22:46:10]

On 2015/10/27 22:21:57, Mark Mentovai wrote:
> LGTM.
> 
> Well, I'm a little less positive about 4706. Where did that one show up?

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/crashp...

and

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/crashp...

I could also rewrite those two instances to not need it I suppose.

[Mark Mentovai, 2015-10-27 22:49:58]

Right, because MSVC++ doesn’t honor the (()) trick to disable that warning.

The LGTM stands!

[scottmg, 2015-10-27 22:50:49]

On 2015/10/27 22:46:10, scottmg wrote:
> On 2015/10/27 22:21:57, Mark Mentovai wrote:
> > LGTM.
> > 
> > Well, I'm a little less positive about 4706. Where did that one show up?
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/crashp...
> 
> and
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/crashp...
> 
> I could also rewrite those two instances to not need it I suppose.

I like ps#4 better, but whichever you prefer is fine with me.

[Mark Mentovai, 2015-10-27 22:59:29]

LGTM on #4 also. My personal preference is while (true) in C++ code, but the for
(;;) is fine also.

[scottmg, 2015-10-27 23:02:54]

On 2015/10/27 22:59:29, Mark Mentovai wrote:
> LGTM on #4 also. My personal preference is while (true) in C++ code, but the
for
> (;;) is fine also.

It's 878
https://code.google.com/p/chromium/codesearch#search/&q=%22while%20(true)%22&...
to 872
https://code.google.com/p/chromium/codesearch#search/&q=%22for%20(;;)%22&sq=p...
! Very close. :)

I prefer "for (;;)" because on Windows "while (true)" triggers a "conditional
expression is constant" warning. We happen to also have that one disabled, so it
doesn't matter too much.

[scottmg, 2015-10-27 23:03:32]

Committed patchset #4 (id:60001) manually as
ba0e7de07b01490348e6f00dbbca47f312dd6f4a (presubmit successful).