Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1430483002: [turbofan] Fix OSR-ed callee trigged ty do-expressions. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
caitp (gmail), rossberg
CC:
v8-reviews_googlegroups.com, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix OSR-ed callee trigged ty do-expressions. This fixes a missing SSA-renaming of the callee value used in the frame state of a call node. An OSR-entry within do-expressions contained in one of the argument expression can trigger that renaming. R=rossberg@chromium.org TEST=mjsunit/regress/regress-crbug-546968 BUG=chromium:546968 LOG=n Committed: https://crrev.com/f8465b45f7010adf3012d785bfc4ed217ad75404 Cr-Commit-Position: refs/heads/master@{#31613}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +2 lines, -1 line 1 comment Download
A + test/mjsunit/regress/regress-crbug-546968.js View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-27 16:58:38 UTC) #1
rossberg
Thanks! LGTM, although I can't claim I really understand why this fixes it. :)
5 years, 1 month ago (2015-10-27 17:03:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430483002/1
5 years, 1 month ago (2015-10-27 17:18:52 UTC) #4
caitp (gmail)
https://codereview.chromium.org/1430483002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1430483002/diff/1/src/compiler/ast-graph-builder.cc#newcode1660 src/compiler/ast-graph-builder.cc:1660: ast_context()->ReplaceValue(); Question: why does this matter? It looks like ...
5 years, 1 month ago (2015-10-27 17:19:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 17:21:03 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 17:21:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8465b45f7010adf3012d785bfc4ed217ad75404
Cr-Commit-Position: refs/heads/master@{#31613}

Powered by Google App Engine
This is Rietveld 408576698