Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1430483002: [turbofan] Fix OSR-ed callee trigged ty do-expressions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-546968.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index ad17c2c781e8a74106bf3ef85f2c86e65fdb7494..d25fba457249beb2f0e00e29a82463aa3ce1a918 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1657,6 +1657,7 @@ void AstGraphBuilder::VisitNativeFunctionLiteral(NativeFunctionLiteral* expr) {
void AstGraphBuilder::VisitDoExpression(DoExpression* expr) {
VisitBlock(expr->block());
VisitVariableProxy(expr->result());
+ ast_context()->ReplaceValue();
caitp (gmail) 2015/10/27 17:19:05 Question: why does this matter? It looks like it j
}
@@ -2459,7 +2460,7 @@ void AstGraphBuilder::VisitCall(Call* expr) {
const Operator* call = javascript()->CallFunction(args->length() + 2, flags,
language_mode(), feedback);
Node* value = ProcessArguments(call, args->length() + 2);
- environment()->Push(callee_value);
+ environment()->Push(value->InputAt(0)); // The callee passed to the call.
PrepareFrameState(value, expr->ReturnId(), OutputFrameStateCombine::Push());
environment()->Drop(1);
ast_context()->ProduceValue(value);
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-546968.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698