Issue 14302004: Fix an error in the destructor for Shape.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14302004: Fix an error in the destructor for Shape.cc (Closed)

Created:
7 years, 8 months ago by shaowei

Modified:
7 years, 8 months ago

Reviewers:
Josh Horwich, jhorwich, gangji, noahric, Tristan Schmelcher

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/o3d/

Visibility:
Public.

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	build/version.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	core/cross/shape.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

gangji

lgtm FYI, you don't need to bump version every time. Only when you decided to ...

7 years, 8 months ago (2013-04-18 18:48:39 UTC) #2

shaowei

7 years, 8 months ago (2013-04-18 18:49:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r194977 (presubmit successful).