Fix an error in the destructor for Shape.cc

core/cross/shape.cc

 /*
  * Copyright 2009, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 31 matching lines @@
 
 Shape::Shape(ServiceLocator* service_locator)
     : ParamObject(service_locator) {
 }
 
 ObjectBase::Ref Shape::Create(ServiceLocator* service_locator) {
   return ObjectBase::Ref(new Shape(service_locator));
 }
 
 Shape::~Shape() {
+  ElementRefArray copy(elements_.begin(), elements_.end());
   // Unregister any Elements that might think they own us.
-  ElementRefArray::iterator iter, end = elements_.end();
-  for (iter = elements_.begin(); iter != end; ++iter) {
+  ElementRefArray::iterator iter, end = copy.end();
+  for (iter = copy.begin(); iter != end; ++iter) {
     if (iter->Get()) {
       iter->Get()->SetOwner(0);
     }
   }
 }
 
 // Adds a element do this shape.
 void Shape::AddElement(Element* element) {
   elements_.push_back(Element::Ref(element));
 }
@@ skipping 47 matching lines @@
     const DrawElementRefArray& draw_elements = element->GetDrawElementRefs();
     if (std::find_if(draw_elements.begin(),
                      draw_elements.end(),
                      FindByMaterial(material)) == draw_elements.end()) {
       elements_[pp]->CreateDrawElement(pack, material);
     }
   }
 }
 
 }  // namespace o3d