Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1430153002: Log when exiting run-webkit-tests. (Closed)

Created:
5 years, 1 month ago by ojan
Modified:
5 years, 1 month ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log when exiting run-webkit-tests. The windows bot is hanging sometime after the tests are done running. Log to try and diagnose the problem. BUG=522396 Committed: https://crrev.com/738f72f173985d46f0fb1596209981c1cfe1e53a Cr-Commit-Position: refs/heads/master@{#358185}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a finally clause #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 1 chunk +11 lines, -1 line 1 comment Download

Messages

Total messages: 11 (3 generated)
ojan
5 years, 1 month ago (2015-11-05 22:05:44 UTC) #3
ojan
https://codereview.chromium.org/1430153002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right): https://codereview.chromium.org/1430153002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py#newcode413 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:413: if 'win_chromium_rel_ng' in sys.argv: This is a bit hacky, ...
5 years, 1 month ago (2015-11-05 22:08:27 UTC) #4
Dirk Pranke
lgtm, though I expect things are hanging inside sys.exit() since that's where python checks to ...
5 years, 1 month ago (2015-11-05 22:10:44 UTC) #5
ojan
Good point! I added a try/finally around the sys.exit call so we can see that ...
5 years, 1 month ago (2015-11-05 22:24:37 UTC) #6
Dirk Pranke
lgtm. https://codereview.chromium.org/1430153002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (right): https://codereview.chromium.org/1430153002/diff/20001/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py#newcode421 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:421: print "sys.exit completed" # pylint: disable=E1601 interesting. I ...
5 years, 1 month ago (2015-11-05 22:42:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430153002/20001
5 years, 1 month ago (2015-11-05 22:49:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-05 23:59:41 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 00:00:29 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/738f72f173985d46f0fb1596209981c1cfe1e53a
Cr-Commit-Position: refs/heads/master@{#358185}

Powered by Google App Engine
This is Rietveld 408576698