Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 1430153002: Log when exiting run-webkit-tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a finally clause Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index 4c2f2bca62f03947838872fbd3a489f3b1d578e3..dd8a9e8a085f99bb74915a45b9b610814779aeb6 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -408,4 +408,14 @@ def run(port, options, args, logging_stream, stdout):
printer.cleanup()
if __name__ == '__main__':
- sys.exit(main(sys.argv[1:], sys.stdout, sys.stderr))
+ exit_code = main(sys.argv[1:], sys.stdout, sys.stderr)
+ # Temporary logging to try and diagnose hangs on the Windows bots.
+ if 'win_chromium_rel_ng' in sys.argv:
+ print "Exiting with exit code: %d" % exit_code # pylint: disable=E1601
+
+ try:
+ sys.exit(exit_code)
+ finally:
+ # Temporary logging to try and diagnose hangs on the Windows bots.
+ if 'win_chromium_rel_ng' in sys.argv:
+ print "sys.exit completed" # pylint: disable=E1601
Dirk Pranke 2015/11/05 22:42:31 interesting. I wouldn't have thought the finally b
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698