Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1430123003: DevTools: kill WebInspector.SectionCascade class (Closed)

Created:
5 years, 1 month ago by lushnikov
Modified:
5 years, 1 month ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@new-rule-out-of-cascade
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: kill WebInspector.SectionCascade class WI.SectionCascade is another presentation model used by WI.StyleSidebarPane for rendering its sections. This patch removes WI.SectionCascade class altogether, moving SSP to rely on WI.CSSStyleModel.MatchedStyleResult. This is mostly a technical work. BUG=537827 R=pfeldman, dgozman Committed: https://crrev.com/cfa716418fbdfaf601824f05b88254772dafdb59 Cr-Commit-Position: refs/heads/master@{#358745}

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -277 lines) Patch
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleWidget.js View 5 chunks +17 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/elements/StylesSectionModel.js View 1 chunk +0 lines, -206 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 16 chunks +42 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js View 4 chunks +160 lines, -5 lines 12 comments Download

Depends on Patchset:

Messages

Total messages: 15 (3 generated)
lushnikov
ptal
5 years, 1 month ago (2015-11-07 04:28:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430123003/1
5 years, 1 month ago (2015-11-07 23:13:48 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-08 01:39:54 UTC) #5
dgozman
lgtm https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js#newcode2162 third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:2162: return style.parentRule ? style.parentRule.matchingSelectors && style.parentRule.matchingSelectors.length > 0 ...
5 years, 1 month ago (2015-11-09 20:36:42 UTC) #6
lushnikov
https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js#newcode2162 third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:2162: return style.parentRule ? style.parentRule.matchingSelectors && style.parentRule.matchingSelectors.length > 0 && ...
5 years, 1 month ago (2015-11-09 21:42:57 UTC) #7
dgozman
https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js#newcode2169 third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:2169: mediaMatches: function(style) On 2015/11/09 21:42:57, lushnikov wrote: > Rule ...
5 years, 1 month ago (2015-11-09 21:48:29 UTC) #8
lushnikov
https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js#newcode2169 third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:2169: mediaMatches: function(style) This is a CSSRule, but it will ...
5 years, 1 month ago (2015-11-09 21:54:01 UTC) #9
dgozman
https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js#newcode2169 third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:2169: mediaMatches: function(style) On 2015/11/09 21:54:01, lushnikov wrote: > This ...
5 years, 1 month ago (2015-11-09 22:03:36 UTC) #10
lushnikov
https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js File third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js (right): https://codereview.chromium.org/1430123003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js#newcode2169 third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleModel.js:2169: mediaMatches: function(style) On 2015/11/09 22:03:36, dgozman wrote: > > ...
5 years, 1 month ago (2015-11-09 22:11:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1430123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1430123003/1
5 years, 1 month ago (2015-11-10 00:08:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-10 01:58:44 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 02:00:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfa716418fbdfaf601824f05b88254772dafdb59
Cr-Commit-Position: refs/heads/master@{#358745}

Powered by Google App Engine
This is Rietveld 408576698