Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: content/browser/renderer_host/media/media_stream_manager.h

Issue 143003031: Allow retrieval of media device ID salt even after ResourceContext has gone away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add TODO about proper fix. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_manager.h
diff --git a/content/browser/renderer_host/media/media_stream_manager.h b/content/browser/renderer_host/media/media_stream_manager.h
index 4d21a188e524ddc0c2e5d1544a2b1a1506cdaf54..e5131bb59b61ffecea425364ac6b555b8cc09953 100644
--- a/content/browser/renderer_host/media/media_stream_manager.h
+++ b/content/browser/renderer_host/media/media_stream_manager.h
@@ -36,6 +36,7 @@
#include "content/common/content_export.h"
#include "content/common/media/media_stream_options.h"
#include "content/public/browser/media_request_state.h"
+#include "content/public/browser/resource_context.h"
namespace media {
class AudioManager;
@@ -48,7 +49,6 @@ class FakeMediaStreamUIProxy;
class MediaStreamDeviceSettings;
class MediaStreamRequester;
class MediaStreamUIProxy;
-class ResourceContext;
class VideoCaptureManager;
// MediaStreamManager is used to generate and close new media devices, not to
@@ -94,7 +94,7 @@ class CONTENT_EXPORT MediaStreamManager
void GenerateStream(MediaStreamRequester* requester,
int render_process_id,
int render_view_id,
- ResourceContext* rc,
+ const ResourceContext::SaltCallback& sc,
int page_request_id,
const StreamOptions& components,
const GURL& security_origin);
@@ -123,12 +123,12 @@ class CONTENT_EXPORT MediaStreamManager
// plug/unplug. The new device lists will be delivered via media observer to
// MediaCaptureDevicesDispatcher.
virtual std::string EnumerateDevices(MediaStreamRequester* requester,
- int render_process_id,
- int render_view_id,
- ResourceContext* rc,
- int page_request_id,
- MediaStreamType type,
- const GURL& security_origin);
+ int render_process_id,
+ int render_view_id,
+ const ResourceContext::SaltCallback& sc,
+ int page_request_id,
+ MediaStreamType type,
+ const GURL& security_origin);
// Open a device identified by |device_id|. |type| must be either
// MEDIA_DEVICE_AUDIO_CAPTURE or MEDIA_DEVICE_VIDEO_CAPTURE.
@@ -136,7 +136,7 @@ class CONTENT_EXPORT MediaStreamManager
void OpenDevice(MediaStreamRequester* requester,
int render_process_id,
int render_view_id,
- ResourceContext* rc,
+ const ResourceContext::SaltCallback& sc,
int page_request_id,
const std::string& device_id,
MediaStreamType type,
@@ -328,7 +328,7 @@ class CONTENT_EXPORT MediaStreamManager
// given |source_id|, false if nothing matched it.
bool TranslateSourceIdToDeviceId(
MediaStreamType stream_type,
- ResourceContext* rc,
+ const ResourceContext::SaltCallback& rc,
const GURL& security_origin,
const std::string& source_id,
std::string* device_id) const;

Powered by Google App Engine
This is Rietveld 408576698